[MAGNOLIA-8393] Definition app problems are based on read instead of write methods Created: 02/May/22 Updated: 20/Jul/22 Resolved: 30/May/22 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | 6.2.18 |
| Fix Version/s: | 6.3.0 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Roman Kovařík | Assignee: | Antonín Juran |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | VN-Testing | ||
| Σ Remaining Estimate: | Not Specified | Remaining Estimate: | Not Specified |
| Σ Time Spent: | 1d 0.5h | Time Spent: | 1d 0.5h |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Issue Links: |
|
|||||||||||||||||||||||||
| Sub-Tasks: |
|
|||||||||||||||||||||||||
| Template: |
|
|||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
|||||||||||||||||||||||||
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
|||||||||||||||||||||||||
| Bug DoR: |
[X]*
Steps to reproduce, expected, and actual results filled
[X]*
Affected version filled
|
|||||||||||||||||||||||||
| Date of First Response: | ||||||||||||||||||||||||||
| Epic Link: | Nucleus Quality Maintenance | |||||||||||||||||||||||||
| Sprint: | Nucleus 11 | |||||||||||||||||||||||||
| Story Points: | 3 | |||||||||||||||||||||||||
| Team: | ||||||||||||||||||||||||||
| Description |
|
Steps to reproduce Use this field config in a dialog or an app:
aField:
$type: sliderField
gridStepSize: 1
Expected results: A definition app error: Property renamed. Keeping the method here for binary compatibility. Use info.magnolia.ui.field.SliderFieldDefinition.setDisplayStepSize(double) instead.
Actual results: An error in the def. app without a description because the deprecation is retrieved from the read method.
The problem description doesn't reach the def. app unless we use the write method to get the annotation see DeprecationUtil |
| Comments |
| Comment by Roman Kovařík [ 02/May/22 ] |
|
Discovery: Looks like the logic should be based on the read instead of write methods (that's the one we use to set the properties, not write the method). To retain compatibility, we might need to fallback to the read method to get the deprecation as well. |
| Comment by Rabie Hayoun [ 13/May/22 ] |
|
Need to spilt is on 2 ticket, add step to reproduce, also current behavior/expected behavior and AC |
| Comment by Roman Kovařík [ 26/May/22 ] |
|
Splitted in
|