[MAGNOLIA-8481] Review ConfigurationSource / Registry refactoring potential blindspots Created: 22/Jun/22  Updated: 18/Jan/24

Status: Selected
Project: Magnolia
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Neutral
Reporter: Maxime Michel Assignee: Mikaël Geljić
Resolution: Unresolved Votes: 0
Labels: dx-core-6.3
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MGNLCT-190 adding new CT does NOT create workspace Accepted
relation
is related to MAGNOLIA-8044 Invert dependency between Registry an... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Epic Link: 6.3 Consolidation
T-Shirt Size: Large
Work Started:

 Description   

There is still a few loose ends around MAGNOLIA-8044:

Missing tests

Some test / test assertions have been commented out without a replacement. Amongst maybe others:

YamlDefinitionDecoratorTest#cannotDecorateMapProblemShouldHaveSevereLevel
YamlConfigurationSourceTest#...

Deprecations without (indicating) replacements 

Some entities have been deprecated without indicating how to replace their functionality. Amongst maybe others in:

AbstractRegistry
JcrConfigurationSourceBuilder
ConfigurationSourceBuilder

Breaking changes 

There are breaking changes causing downstream failures. See e.g. MGNLRESTCL-179. One of which is the AbstractRegistry#onRegister and AbstractRegistry#register call backs not being called anymore.

Tasks

  • Re-establish full test coverage
  • Document deprecations and indicate replacements
  • Reintroduce functionality that causes breaking changes if possible. Otherwise document how adjust client code.

Generated at Mon Feb 12 04:33:06 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.