[MAGNOLIA-8575] As Magnolia developer I need a mechanism to group several "atomic" actions into a single one Created: 11/Aug/22 Updated: 25/Nov/22 |
|
| Status: | Open |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Spike | Priority: | Low |
| Reporter: | David Lopez | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Σ Remaining Estimate: | Not Specified | Remaining Estimate: | Not Specified |
| Σ Time Spent: | Not Specified | Time Spent: | Not Specified |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Issue Links: |
|
|||||||||||||||||||||||||
| Sub-Tasks: |
|
|||||||||||||||||||||||||
| Template: |
|
|||||||||||||||||||||||||
| Date of First Response: | ||||||||||||||||||||||||||
| Epic Link: | Externalize JCR configuration | |||||||||||||||||||||||||
| Team: | ||||||||||||||||||||||||||
| Description |
| Comments |
| Comment by David Lopez [ 17/Aug/22 ] |
Refinement 17/08/22Hi jsimak , Would it be possible to have the scenario (use case) that we would use this functionality in order we can use it as acceptance criteria and/or test to validate that what we build?
Questions
Feel free to add any further information you would find relevant. If you think a quick call might be more fruitful (Rabie, Roman and myself would be the right audience) |
| Comment by Jaroslav Simak [ 19/Aug/22 ] |
|
Hi dlopez, We can consider two use cases:
Both of these use cases follow the same process. Action triggers publication action, which delegates to a configured command chain (usually consists of version and publish commands) defined in the action definition. Webhooks module adds new command to the command chain (version -> publish -> webhook). Once user publishes a page, and if publication is successful, the webhook command is triggered and notifies the 3rd party service defined in the webhook definition. The webhook command sends this data to the 3rd party:
The only difference between single and recursive node publication is what is sent in recursive property (either false if single node or true if recursive). |
| Comment by Roman Kovařík [ 24/Aug/22 ] |
|
Discovery: Events can be plugged at different levels (Assuming we can add dependency to webhooks at that level):
The current implementation https://git.magnolia-cms.com/projects/ENTERPRISE/repos/webhooks/browse/magnolia-webhooks-core/src/main/java/info/magnolia/webhooks/command/BaseWebhookCommand.java Concern: Webhook is a licensed module!
|
| Comment by Antonín Juran [ 24/Aug/22 ] |
|
rkovarik Would be possible to use the webhooks module as it is since it depends on JCR? |
| Comment by Roman Kovařík [ 24/Aug/22 ] |
|
Good point, jsimak is it necessary to have JCR in webhooks API?
|
| Comment by Jaroslav Simak [ 24/Aug/22 ] |
|
Once we have support from Norsu for events, we will create implementation specific submodules, so that the core and / or events doesn't depend on JCR. |
| Comment by Roman Kovařík [ 24/Aug/22 ] |
Do you expect some generic support? The tickets describes only publication. We were expecting to be able to use the webhook API (when it will be JCR agnostic), not vice versa. |
| Comment by Jorge Franco [ 24/Aug/22 ] |
|
I have created a PoC of some generic magnolia-events, that can be used for this initiative. https://git.magnolia-cms.com/projects/CLOUD/repos/norsu/pull-requests/182/overview. Let me know if you want to go this way |
| Comment by David Lopez [ 24/Aug/22 ] |
Backlog check 24/08/2022Suggested steps
|
| Comment by David Lopez [ 29/Sep/22 ] |
Discussion Backlog check 29/09/2022Although created in Norsu, it relates more to UI
Discussion
ActionsToDo dlopez
|