[MAGNOLIA-8580] Failing [module config] decorator prevents other decorators from being applied Created: 30/Sep/22  Updated: 23/Oct/23  Resolved: 11/Nov/22

Status: Closed
Project: Magnolia
Component/s: configuration
Affects Version/s: 6.2.10, 6.2.25
Fix Version/s: 6.3.0, 6.2.27

Type: Bug Priority: Major
Reporter: Aleksandr Pchelintcev Assignee: Jaroslav Simak
Resolution: Fixed Votes: 0
Labels: None
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: Not Specified Time Spent: Not Specified
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Sub-Tasks:
Key
Summary
Type
Status
Assignee
MAGNOLIA-8618 Implementation Sub-task Closed Jaroslav Simak  
MAGNOLIA-8619 Review Sub-task Closed Rishab Dhar  
MAGNOLIA-8620 PiQA Sub-task Closed Rishab Dhar  
MAGNOLIA-8621 QA Sub-task Completed Milan Divilek  
MAGNOLIA-8633 Port to master Sub-task Completed Jaroslav Simak  
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: DevX Bucket
Sprint: DevX 23
Story Points: 2
Team: DeveloperX

 Description   

Steps to reproduce

  1.  Create a decorator for a non-existing module
  2.  Create a decorator for an existing module (but so that this one is applied after a previous one).

Expected results

The malicious one is not applied, while the legit one should've been picked up without a problem.

Actual results

The whole sequence of decorators is not applied. You should see an error in module startup logs.

Workaround

Explicitly get rid of the malicious decorator, much like it has been e.g. in this change for free trials that suffered after an update that has been removing ranker (FT infra was bringing in a decorator to disable ranker).

Development notes

Whether this concerns only module configs or also the "conventional" registries is not verified yet, there's a chance that those are un-affected.


Generated at Mon Feb 12 04:33:58 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.