[MAGNOLIA-8672] Bump smallrye from 2.4.1 to 2.13.3 & adapt GroupedPropertiesResolver Created: 22/Dec/22 Updated: 23/Oct/23 Resolved: 01/Sep/23 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.3.0 |
| Type: | Task | Priority: | Neutral |
| Reporter: | Maxime Michel | Assignee: | Milan Divilek |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Σ Remaining Estimate: | Not Specified | Remaining Estimate: | Not Specified |
| Σ Time Spent: | 4.5h | Time Spent: | 4.5h |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Attachments: |
|
|||||||||||||||||||||||||
| Sub-Tasks: |
|
|||||||||||||||||||||||||
| Template: |
|
|||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
|||||||||||||||||||||||||
| Task DoR: |
Empty
|
|||||||||||||||||||||||||
| Date of First Response: | ||||||||||||||||||||||||||
| Epic Link: | DevX Bucket | |||||||||||||||||||||||||
| Sprint: | DevX 45 | |||||||||||||||||||||||||
| Story Points: | 2 | |||||||||||||||||||||||||
| Team: | ||||||||||||||||||||||||||
| Work Started: | ||||||||||||||||||||||||||
| Approved: |
Yes
|
| Description |
|
Initial suggestion of Renovate: https://git.magnolia-cms.com/projects/BUILD/repos/boms/pull-requests/870/overview While it appeared fine before merging, it ended up breaking the logic of GroupedPropertiesResolver when it comes to parsing the defaultCorsConfiguration. This failed MicroprofileConfigSupportModuleTest#mapPropertiesTest, and later the SaaS webapp. I have found a workaround that seems to do the job here: https://git.magnolia-cms.com/projects/PLATFORM/repos/main/pull-requests/1201/diff However, I am not comfortable merging this myself. Hence I would like the domain team or the initial author/reviewers to handle it. Thanks. |
| Comments |
| Comment by Oanh Thai Hoang [ 15/Feb/23 ] |
|
From what I understand after reading source code of releasing https://github.com/smallrye/smallrye-config/releases/tag/2.4.2. There is improvements from https://github.com/smallrye/smallrye-config/pull/612/commits/d2bc680609d9d6f3691cdc951ac1537b60de31c1. Since 2.4.2, when working with list of string YamlConfigSource always put index form as property for better handle null list.
Since we need to adapt with the flatten list property change from smallrye. Confirm the proposed solution works.
|