[MAGNOLIA-8785] Page status not modified when editing component variants Created: 18/Oct/22  Updated: 01/Mar/23  Resolved: 28/Feb/23

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 6.2.28
Fix Version/s: 6.2.29

Type: Bug Priority: Neutral
Reporter: Roberto Gaona Assignee: Miguel Martinez
Resolution: Fixed Votes: 0
Labels: None
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: 3h Time Spent: 3h
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Attachments: PNG File image-2022-10-18-13-59-04-445.png     PNG File image-2022-10-18-13-59-35-025.png    
Issue Links:
Relates
relates to MGNLPN-704 DOC: Describe how editing a Component... Closed
causality
Sub-Tasks:
Key
Summary
Type
Status
Assignee
MAGNOLIA-8789 Port to Master Sub-task To Do  
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[X]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Release notes required:
Yes
Documentation update required:
Yes
Date of First Response:
Epic Link: AuthorX Support
Sprint: AuthX 28
Story Points: 5
Team: AuthorX
Work Started:

 Description   

Steps to reproduce

  1. Create a component variant on any page and publish changes.
  2. Edit such component variant and check the page status from the browser view

Expected results

  • Page status reflects the modified component variant with the green yellow circle
  • the modified changes will need to be approved/published by the editor 

Actual results

  • The changes are immediately published on the public instance
  • Page appears as published (green) on browser view:

Yet a component variant appears as modified:

Workaround

NA

Development notes



 Comments   
Comment by Miguel Martinez [ 09/Jan/23 ]

I searched for the yellow dot status behaviour that is has not been decorated yet,

For this it needs to be implemented and decorated in the pages-app.yaml from personalization , and add a new decorator for the status that understands the variant and how to see if it has been modified like in 

src/main/java/info/magnolia/personalization/filter/VariantResolverFilter.java

In regard of the 

The changes are immediately published on the public instance

That is wrong, given that is is the same demo instance (same urls) and not a public one . Tried on local public instance and it was published correctly 

 

Generated at Mon Feb 12 04:35:46 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.