[MAGNOLIA-8850] Make renderType optional and show info message if the render type is not exist Created: 24/Mar/23 Updated: 28/Mar/23 |
|
| Status: | Open |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Canh Nguyen | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Σ Remaining Estimate: | Not Specified | Remaining Estimate: | Not Specified |
| Σ Time Spent: | Not Specified | Time Spent: | Not Specified |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Issue Links: |
|
||||||||||||||||||||||||||||||
| Sub-Tasks: |
|
||||||||||||||||||||||||||||||
| Template: | |||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||
| Epic Link: | DevX Bucket | ||||||||||||||||||||||||||||||
| Team: | |||||||||||||||||||||||||||||||
| Description |
|
Many customers use External Page Editor to work with SPA, so renderType from TemplateDefinition is not needed anymore. We want to remove renderType from SPA definition. The template validation should not show major problem on the Definition App. It should show info message only if users set a render type that is not registered. We might need to have a fallback renderer that renders a message for users to be aware of a render type that they used, is not registered in case they try to access our rendering service. e.g. http://localhost:8080/magnoliaAuthor/aPage.html |
| Comments |
| Comment by Christopher Zimmermann [ 27/Mar/23 ] |
|
Would a customer want to create a custom renderType possibly? Or might there be customers that have them? |
| Comment by Christopher Zimmermann [ 27/Mar/23 ] |
|
Also - some examples here have renderType for the area. Is that needed?
areas:
header:
renderType: spa
title: Header
|
| Comment by Canh Nguyen [ 27/Mar/23 ] |
Customers still can create custom renderers and the URL to access the render engine like this URL http://localhost:8080/magnoliaAuthor/aPage.html . So they still can use resource app to host JS files and set baseUrl and routeTemplate to magnolia server.
This is redundant. We don't need to set renderType for areas in SPA template definitions. |
| Comment by Christopher Zimmermann [ 28/Mar/23 ] |
|
OK from my side. |