[MAGNOLIA-8850] Make renderType optional and show info message if the render type is not exist Created: 24/Mar/23  Updated: 28/Mar/23

Status: Open
Project: Magnolia
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Canh Nguyen Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: Not Specified Time Spent: Not Specified
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Issue Links:
Relates
relates to PAGES-1101 Deprecate support for magnolia-hosted... Closed
Sub-Tasks:
Key
Summary
Type
Status
Assignee
MAGNOLIA-8851 Implementation Sub-task To Do  
MAGNOLIA-8852 Review Sub-task To Do  
MAGNOLIA-8853 Pre-Integration QA Sub-task To Do  
MAGNOLIA-8854 QA Sub-task To Do  
MAGNOLIA-8857 DOC: renderType is optional in Extern... Sub-task To Do Martin Drápela  
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: DevX Bucket
Team: DeveloperX

 Description   

Many customers use External Page Editor to work with SPA, so renderType from TemplateDefinition is not needed anymore. We want to remove renderType from SPA definition. The template validation should not show major problem on the Definition App. It should show info message only if users set a render type that is not registered.

We might need to have a fallback renderer that renders a message for users to be aware of a render type that they used, is not registered in case they try to access our rendering service.

e.g. http://localhost:8080/magnoliaAuthor/aPage.html 



 Comments   
Comment by Christopher Zimmermann [ 27/Mar/23 ]

Would a customer want to create a custom renderType possibly? Or might there be customers that have them?

https://docs.magnolia-cms.com/product-docs/6.2/Developing/Templating/Renderers.html#_creating_a_custom_renderer

canh.nguyen jsimak 

Comment by Christopher Zimmermann [ 27/Mar/23 ]

Also - some examples here have renderType for the area. Is that needed?

https://docs.magnolia-cms.com/product-docs/6.2/Developing/Templating/Template-definition.html#_site_spa_render_type

areas:
  header:
    renderType: spa
    title: Header 
Comment by Canh Nguyen [ 27/Mar/23 ]

Would a customer want to create a custom renderType possibly? Or might there be customers that have them?

Customers still can create custom renderers and the URL to access the render engine like this URL  http://localhost:8080/magnoliaAuthor/aPage.html . So they still can use resource app to host JS files and set baseUrl and routeTemplate to magnolia server.

Also - some examples here have renderType for the area. Is that needed?

 This is redundant. We don't need to set renderType for areas in SPA template definitions.

Comment by Christopher Zimmermann [ 28/Mar/23 ]

OK from my side.

Generated at Mon Feb 12 04:36:21 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.