[MAGNOLIA-9031] [DX-core] Definitions app should show problem when dialog field $type is wrong Created: 23/Jun/23  Updated: 09/Aug/23  Resolved: 08/Aug/23

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: None
Fix Version/s: 6.2.38

Type: Bug Priority: Major
Reporter: Christopher Zimmermann Assignee: Valeria Robles-Garzon
Resolution: Fixed Votes: 0
Labels: None
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: 1.5h Time Spent: 1.5h
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Issue Links:
Cloners
is cloned by CFGUI-182 [SAAS] - Definitions app should show ... Open
Relates
relates to MGNLTEST-428 CE 6.2 and 6.3 pipelines unstable due... Closed
Sub-Tasks:
Key
Summary
Type
Status
Assignee
MAGNOLIA-9032 Implement Sub-task Completed Valeria Robles-Garzon  
MAGNOLIA-9033 Review Sub-task Completed Javier Benito  
MAGNOLIA-9034 QA 6.3 Sub-task Completed Dai Ha  
MAGNOLIA-9035 Pre-Integration QA Sub-task Completed Javier Benito  
MAGNOLIA-9045 QA 6.2 Sub-task Completed Rishab Dhar  
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[X]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Release notes required:
Yes
Epic Link: DevX Bucket
Sprint: DevX 43
Story Points: 3
Team: DeveloperX
Work Started:
Approved:
Yes

 Description   

This ticket is for DX-Core, CFGUI-182 is for SaaS.

When developer specifies a field $type that does not exist, a useful warning is displayed in the logs, but no "problem" is displayed in the "Definitions app". A problem should be displayed otherwise it is difficult for a developer to find the cause of the problem. 

The same problem happens on DXCORE and SaaS, but the problem is slightly worse on SaaS as the logs cannot be seen by the developer and the "Configuration Monitor" does not report any problem.

 

To reproduce:

Note that "textArea" is not a valid $type here.

Use the following dialog for a page template: 

 

label: My Page
form:
  properties:
    title:
      label: Title
      $type: textField
      i18n: true
    text2:
      label: Test
      $type: textArea
      i18n: true

 

 

Then create a page of that type and try to edit that page in the page editor. 

> You get an exception that the page cannot be edited.

Go to the Definitions App - notice that there are no problems shown in the Definitions or Problems tab for the incorrect dialog.

Here is the useful warning message in the logs on DXCORE

2023-06-23 11:38:09,763 WARN  a.config.resolver.AnnotationProcessingTypeResolver: Encountered the '$type' property but failed to resolved the type from its value: [textArea]. Available types: [jcrMultiField,radioButtonGroupField,pageLinkField,staticField,textField,comboBoxField,twinColSelectField,checkBoxField,multiField,switchableField,checkBoxGroupField,jcrMultiLinkField,passwordField,compositeField,listSelectField,richTextField,codeField,resourceLinkField,tokenField,linkField,dateField,uploadField,sliderField,jcrMultiValueField,damLinkField,hiddenField] 

 


Generated at Mon Feb 12 04:37:58 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.