[MAGNOLIA-9159] Performance: Publishing site configuration shouldn't trigger module restart Created: 27/Oct/23 Updated: 29/Jan/24 Resolved: 23/Nov/23 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.3.0, 6.2.41 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Oanh Thai Hoang | Assignee: | Oanh Thai Hoang |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | dx-core-6.3 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | 3d | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Release notes required: |
Yes
|
||||||||
| Documentation update required: |
Yes
|
||||||||
| Epic Link: | Throughput improvements | ||||||||
| Work Started: | |||||||||
| Approved: |
Yes
|
||||||||
| Description |
Steps to reproduce
INFO info.magnolia.module.scheduler.CommandJob 27.10.2023 05:59:10 -- Starting job [UI Action triggered execution of [default:activate] by user [superuser]. (0)]... INFO info.magnolia.module.scheduler.CommandJob 27.10.2023 05:59:16 -- Job executed successfully [UI Action triggered execution of [default:activate] by user [superuser]. (0)] INFO info.magnolia.module.ModuleManagerImpl 27.10.2023 05:59:17 -- Stopping module multisite INFO info.magnolia.module.ModuleManagerImpl 27.10.2023 05:59:17 -- Starting module multisite WARN info.magnolia.multisite.registry.MultiSiteRegistry 27.10.2023 05:59:17 -- Maximum number of allowed sites (2) reached. Following sites are registered: [travel, sportstation].
In my case: I have 1000 site. There fore, if I just publish one site and trigger reload + start module then register 1000 site again seem unnecessary to me. See my below log: INFO info.magnolia.module.ModuleManagerImpl 27.10.2023 13:09:19 -- Starting module multisite WARN info.magnolia.multisite.registry.MultiSiteRegistry 27.10.2023 13:09:24 -- Maximum number of allowed sites (1000) reached. Following sites are registered: [test239..] .. Logs, screenshots, gifs... Expected resultsMultisite does not need to reload, stop and start.. Justify non-trivial expectations with a link to a doc or a relevant discussion. Actual resultsWorkaroundDevelopment notesStop/ start multisite because of publishing events seem unnecessary to me. After reload, multisite will start and trigger register all sites again via https://git.magnolia-cms.com/projects/ENTERPRISE/repos/multisite/browse/src/main/java/info/magnolia/multisite/MultiSiteModule.java?at=refs%2Fheads%2Frelease%2F1.3#144
Maybe we can filter out any events related to publishing property in info.magnolia.config.module.ModuleJcrConfigurationSource
|