[MAGNOLIA-9174] Introduce magnolia.resources.filesystem.observation. excludedPatterns property to config addition exclude regex for file system Created: 07/Nov/23  Updated: 01/Feb/24

Status: Selected
Project: Magnolia
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Oanh Thai Hoang Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: dx-core-6.3
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MAGNOLIA-7358 Performance: Resource origin should i... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Documentation update required:
Yes
Epic Link: Throughput improvements
Work Started:

 Description   

Follow up from https://jira.magnolia-cms.com/browse/MAGNOLIA-7358

 

Problem: 

Issue was discovered when investigating rendering performance issue in instance with node_modules directory in light module (brought in by use of webpack) and it containing additional 30K files (facepalm). This fact, together with multiple calls to resfn in single template lead to performance issue (traversing of 40K files while searching for resources took approx 2 seconds).

 

Improvement suggestion:

  • reference to comment link: this is a different issue. However, it is also an understandable one and can be possibly addressed by altering the property magnolia.resources.filesystem.observation.excludedDirectories, which should contain comma-separated list of directories to be not included into FS resource origin (I am not sure if that property supports *-templates tho, if not - we should add such support).
  • https://git.magnolia-cms.com/projects/PLATFORM/repos/main/pull-requests/1376/overview?commentId=122700 : From a more general point of view, while this approach works, I'm not sure how useful it is to a developer of a light module. Such a developer cannot easily change these properties. I think we need another approach in addition to the changes in this PR that allow a developer of a light module to configure exclusions from the light module itself. Let's create a separate ticket for this as needed.

 


Generated at Mon Feb 12 04:39:15 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.