[MAGNOLIA-926] Replace servlets by filters Created: 11/Jun/06 Updated: 17/Mar/09 Resolved: 15/Nov/06 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | core |
| Affects Version/s: | 3.0 Beta 1 |
| Fix Version/s: | 3.0 Final |
| Type: | Improvement | Priority: | Critical |
| Reporter: | Fabrizio Giustina | Assignee: | Philipp Bärfuss |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
We should explore some possible enhancements:
|
| Comments |
| Comment by Philipp Bracher [ 12/Jun/06 ] |
|
To make the EntryServlet a filter and threfore chainable would be very powerfull. We should definitely follow this idea. Doing this we should also refactor the entry servlet so that it handles multiple repository requests:
for dms it is tempararely solved by an own servlet. We should avoid this in the future. |
| Comment by Fabrizio Giustina [ 09/Jul/06 ] |
|
I already moved most of the operations to filters, the code looks a lot easier to maintain than manually chaining operations in a single servlet:
CacheFilter doesn't work at the moment since it needs to be configured in the filter chain just before the CmsFilter. Will be easy to do as soon as the filter list (at the moment in a costant into MagnoliaManagedFilter) will be moved to the config jcr. Absolutely needs some tests before a rc3, but it could be a great improvement... and we should go on removing all the servlets in web.xml (ActivatorHandler could be removed and managed like InterceptFilter does, and Import/Export should be moved to a page). |
| Comment by Boris Kraft [ 12/Oct/06 ] |
|
Is this completed? |
| Comment by Magnolia International [ 15/Nov/06 ] |
|
All this was done some time ago (started before rc1 and finished before rc4)
|