[MAGNOLIA-9282] Yaml configuration does not inherit configuration in JCR Created: 25/Dec/23  Updated: 07/Feb/24  Resolved: 07/Feb/24

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 6.3.0
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Lam Nguyen Bao Assignee: Unassigned
Resolution: Workaround exists Votes: 0
Labels: dx-core-6.3
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File image-2024-01-12-22-36-57-198.png    
Issue Links:
Cloners
is cloned by CONTEDIT-609 Stories are not rendered on 6.3 Closed
Relates
relates to MAGNOLIA-8433 DX Core 6.3 Consolidation Selected
documentation
to be documented by MAGNOLIA-9283 DOC: Inheriting from JCR doesn't work... Open
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Release notes required:
Yes
Documentation update required:
Yes
Date of First Response:
Epic Link: 6.3 Consolidation
T-Shirt Size: Medium
Team: AuthorX
Work Started:

 Description   

Stories are not rendered on 6.3

https://nightly-63.magnolia-cms.com/.magnolia/admincentral#app:pages-app:detail;/travel/stories:edit

Dev notes:

There're errors on browser console, template definitions and logtools



 Comments   
Comment by Mikaël Geljić [ 16/Jan/24 ]

Inherited definition at [freemarker] either does not exist or is not loaded because of the missing module dependency in module [block-templating], which currently depends only on [core, templating, rendering, site]
Title: Missing definition dependency
Path: /

despite freemarker definition being present and valid.

it seems either YAML inheritance doesn't work there anymore, or inheriting from JCR doesn't; see plain usage at content-editor-freemarker.yaml

Comment by Mikaël Geljić [ 07/Feb/24 ]

Upon further analysis, we are not considering restoring YAML inherits from JCR, due to simplifications in the ConfigurationSources implementation and general trend to move definitions from JCR to YAML.

The initial issue (stories app not rendering because of renderer definitions using such inherits) has been fixed by moving/replacing the inherit with proper YAML definition.

Worth noting that we tried to migrate the freemarker renderer definition to YAML, and use decorations to provide templating-functions from various modules, however inheriting the original definition currently comes without the decorators.

Therefore, we recommend the workaround above to migrate or replicate the inherited JCR definition into YAML (and not to use inherits, if decorators are expected for the time being).

Generated at Mon Feb 12 04:40:15 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.