[MAGNOLIA-985] cleanup of import methods in DataTransporter (and depending classes) as preliminary work for new XSL transformation feature Created: 24/Jul/06 Updated: 23/Jan/13 Resolved: 05/Sep/06 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | core |
| Affects Version/s: | 3.0 RC3 |
| Fix Version/s: | 3.0 RC3 |
| Type: | Improvement | Priority: | Minor |
| Reporter: | Oliver Lietz | Assignee: | Philipp Bärfuss |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Date of First Response: |
| Description |
|
Renamed methods, made them more consistent and improved javadoc. This is preliminary work for a new XSL transformation feature. The methods for XSL transformation are also in "DataTransporter" namely "transformXmlStream" and "getXslStreamForXmlFile". |
| Comments |
| Comment by Oliver Lietz [ 24/Jul/06 ] |
|
One new dependency for XSL transformation: CircularByteBuffer from com.Ostermiller.util.* http://ostermiller.org/utils/CircularBuffer.html license: GNU General Public License |
| Comment by Nicolas Modrzyk [ 25/Jul/06 ] |
|
you can't introduce code that is under the GPL license into Magnolia. This is a copyright breached since Magnolia is LGPL. |
| Comment by Oliver Lietz [ 29/Jul/06 ] |
|
Had the license issue in mind, but couldn't find anything on the website and the wiki. Therefore I named the license explicitly. |
| Comment by Oliver Lietz [ 01/Aug/06 ] |
|
updated diff against revision 5692 |
| Comment by Philipp Bracher [ 05/Sep/06 ] |
|
I dicided to use properties files instead of the xsl mechanism. I think it is much handier. |