[MGNLACTIVATION-25] Missing outputstream close in transporter prevents deletion of mgnl_activation temp files Created: 03/May/13  Updated: 19/Nov/13  Resolved: 18/Nov/13

Status: Closed
Project: Activation
Component/s: None
Affects Version/s: 5.0
Fix Version/s: 5.1.1, 5.2

Type: Bug Priority: Major
Reporter: Peter Varga Assignee: Milan Divilek
Resolution: Fixed Votes: 0
Labels: exchangesimple
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Windows jre6 magnolia 4.5.6


Issue Links:
Cloners
is cloned by MAGNOLIA-5497 Missing outputstream close in transpo... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: 5.2-rc2

 Description   

Might be not the right project, please move if needed.
Closing of DataOutputStream dos is missing from info.magnolia.module.exchangesimple.Transporter prepareTempFile method. This suspectedly prevents in most cases the deletion of temporary .mgnl_activation files in Transporter.transport method.
It seems that this problem can be found in 5.0 sources as well.



 Comments   
Comment by Federico Grilli [ 18/Nov/13 ]

I'd like to see both input and output streams closed in a finally block. Furthermore, imo, that should be ported to 4.5.x and possibly 4.4.x branch too.

Generated at Sun Feb 11 22:58:55 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.