[MGNLACTIVATION-44] Switching the template of a page cannot be activated to the public instance. Created: 06/Nov/13 Updated: 14/Nov/13 Resolved: 13/Nov/13 |
|
| Status: | Closed |
| Project: | Activation |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.1.1, 5.2 |
| Type: | Bug | Priority: | Blocker |
| Reporter: | Christopher Zimmermann | Assignee: | Milan Divilek |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Date of First Response: | |
| Sprint: | 5.2-rc1, 5.1.2 |
| Description |
|
This doesn't work for existing pages on public instance. (CE/EE) The issue is caused by changes in metadata. They are not subnodes anymore and receive filter doesn't update "mgnl:*" properties in activated node. We have to change info.magnolia.module.activation.ReceiveFilter.copyProperties(Content, Content) method to also change "mgnl:*" properties |
| Comments |
| Comment by Tobias Mattsson [ 12/Nov/13 ] |
|
When copying a single-valued property you're calling getString() on its value. This converts all properties from their original types to strings. The check that excluded binary node data made sense for the content api where binaries where actually nodes. In the JCR API however that's not the case and they cannot be skipped. Also, can you add to the ticket what was causing the issue? |