[MGNLACTIVATION-58] Disable deactivation and enable activation without UUID check in Configuration for the first and second level nodes Created: 17/Jan/12  Updated: 26/Oct/16  Resolved: 05/May/15

Status: Closed
Project: Activation
Component/s: None
Affects Version/s: 5.0
Fix Version/s: 5.3.3

Type: Improvement Priority: Neutral
Reporter: Jan Haderka Assignee: Evzen Fochr
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MAGNOLIA-5057 Disable activation options in Configu... Closed
relates to MGNLACTIVATION-127 Make it possible to configure activat... Closed
causality
dependency
is depended upon by MGNLCAMPU-26 Increase dependency to activation 5.3.3 Open
is depended upon by MAGNOLIA-6205 Add UITest for "Disable deactivation ... Closed
is depended upon by MGNLXAA-90 Disable deactivation and enable activ... Closed
relation
is related to MGNLUI-3426 Disable unPublish action in Configura... Closed
is related to MGNLUI-3677 Backport – Disable unPublish action i... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

For config workspace and its lvl1 and 2 nodes disable deactivation to prevent accidental damage to the instance. Activation should be done by only checking existence of path, because nodes generated during installation have different UUID's on author and public instance and change of UUID is done delete -> create that can broke public instance.



 Comments   
Comment by Evzen Fochr [ 15/Apr/15 ]

For config workspace, level 1 and 2 nodes, RecieveFilter:
1) publish - check only path, not uuid
2) unpublish - skip, do not allow removal of these nodes by deactivation command (still possible to delete them from admincentral)

Comment by Jan Haderka [ 17/Apr/15 ]

Ever tried using for example StringUtils.countMatches("/some/path", "/")?

Comment by Jan Haderka [ 17/Apr/15 ]

Plus I believe the title of the issue and possibly the description as well do not match anymore the reality of the fix.

Comment by Jan Haderka [ 20/Apr/15 ]

looks better, but I would suggest to reverse checks in if statements (one for header and one for path) to make sure they never end up in NPE.

Comment by Roman Kovařík [ 05/May/15 ]

QA: You get no exception / message when trying to deactivate a module node since it tries to get node by UUID and ends up in catch block with only the debug message:

info.magnolia.module.activation.ReceiveFilter#remove {
...
   } catch (ItemNotFoundException e) {
            log.debug("Unable to delete node", e);
        }
        return handle;
    }

Activation seems to work OK.

Generated at Sun Feb 11 22:59:16 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.