[MGNLACTIVATION-69] Non-activated nodes cannot be deleted without switching off subscriber Created: 08/Dec/13  Updated: 15/Mar/21  Resolved: 15/Mar/21

Status: Closed
Project: Activation
Component/s: None
Affects Version/s: 5.2
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Mikaël Geljić Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: deletion, ideas, undo/redo, usability
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
caused by MGNLACTIVATION-49 Deleted node is not deactivated from ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

Since MGNLACTIVATION-49:

In config app, nodes/properties can no longer be deleted when public instance
is not reachable. We only get an error notification. This doesn't make sense, considering such nodes are not on public at all. This is not consistent either because you can still create new nodes, rename them, but not delete them.



 Comments   
Comment by Jan Haderka [ 09/Dec/13 ]

Multiple things:

  • this is consistent with way Magnolia worked since introduction of deletion command/workflow
  • having active subscriber for non existing instance is incorrect configuration. Fixing this configuration error, the issue described in the ticket goes away. All Magnolia does in this case is making sure there is no inconsistency between configured (but unreachable) public instance and author. As a developer working w/ single instance you should not have any active subscribers.
  • since in config workspace we create many nodes programatically upon installation, there is no way we can ever guarantee that node that is not marked as "not activated" doesn't actually exist in public instance as well
  • in other workspaces then config the mark-as-deleted functionality also supplement missing undo/redo functionality and can't be modified until we have undo/redo

The above being said, this bug report should be converted into a part of undo/redo story/epic as it clearly depends on it.

Comment by Mikaël Geljić [ 12/Dec/13 ]

Ok definitely makes sense considering the active subscriber configuration.

Now from a developer's perspective, how about having the default subscriber inactive by default / set active through magnoliaAuthor properties, or something along these lines?
I guess it's not an isolated use case to run a single instance at development time.

Comment by Evzen Fochr [ 25/Mar/15 ]

If you create new public (by copy paste f.e.), Author instance don't know about its nodes, so if you try to "publish deletion" something marked as "not activated" you still must check all your public instances if node is there and needs to be deleted. And if one or more public have incorrect configuration, it correctly aboard operation.

Generated at Sun Feb 11 22:59:23 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.