[MGNLACTIVATION-85] Do not activate pages already active Created: 04/Jun/14  Updated: 23/Sep/14  Resolved: 22/Sep/14

Status: Closed
Project: Activation
Component/s: None
Affects Version/s: None
Fix Version/s: 5.3.1

Type: New Feature Priority: Neutral
Reporter: Teresa Miyar Assignee: Evzen Fochr
Resolution: Fixed Votes: 0
Labels: support
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLUI-3147 Add property modifiedOnly to tell whe... Closed
Template:
Acceptance criteria:
Empty
Release notes required:
Yes
Date of First Response:

 Description   

Although this feature will have to take into account we can't assume that page is in a same state on public just because it has green activation status (e.g. import or clone or manipulation via unwrapped jcr api) so whatever we do, it still has to be possible to activate even the page that is marked as activated

Added option to publish only unpublished or modified pages, while Publishing pages incl. subnodes. To turn on this feature add new property to node cofiguration>modules>pages>apps>pages>subapps>browser>actions>activateRecursive - new property modifiedOnly with value true



 Comments   
Comment by Magnolia International [ 06/Aug/14 ]

What's the reasoning ?
What do we gain by implementing this ?

Comment by Christian Ringele [ 06/Aug/14 ]

The reason is, that if you activate a tree recursively, and 50% of the pages have already been activated and status is "green", activation would be 50% faster.

Comment by Jan Haderka [ 12/Sep/14 ]

While the code change itself looks functional I have following issues with the ticket as a whole:

  • variable name. I would suggest to rename it to modifiedOnly
  • tests. In none of the added tests it is clear what the status of activated nodes is prior to activation and that they are indeed pages. There should be precondition check prior to executing activation to make sure that if someone modifies test data, they don't render the test useless without noticing.
  • ticket. Change like this absolutely requires release notes and in the ticket it should be described where/how one can configure new property in Magnolia to enable this behaviour. In essence: What do I need to change in "Publish incl. Subpages" configuration to enable it?
Comment by Jan Haderka [ 12/Sep/14 ]

BTW there is also assertEquals

Comment by Roman Kovařík [ 22/Sep/14 ]

QA: it's possible to use modifiedOnly property with non recursive activation, but it's not reflected.

Generated at Sun Feb 11 22:59:32 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.