[MGNLADMLEG-36] i18n: some app labels & icons are still hardcoded in configuration Created: 06/Nov/13  Updated: 18/Nov/13  Resolved: 06/Nov/13

Status: Closed
Project: Admininterface Legacy 4.x (closed)
Component/s: None
Affects Version/s: 5.1.1
Fix Version/s: 5.1.2

Type: Bug Priority: Neutral
Reporter: Christopher Zimmermann Assignee: Christopher Zimmermann
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Cloners
is cloned by MGNLADMLEG-39 CLONE - i18n: some app labels & icons... Closed
dependency
is depended upon by MGNLUI-2329 i18n: some app labels & icons are sti... Closed
Template:
Acceptance criteria:
Empty
Date of First Response:
Sprint: 5.1.2

 Description   

Some changes are necessary so that legacy apps are not created with hardcoded icons and labels.

Change AdminModuleVersionHandler.java to not specify icons or labels to avoid confusion for future developers.
Change WrapLegacyModuleUIAsMagnoliaAppTask.java so that when icons or labels are not specified - then these properties are not added.



 Comments   
Comment by Christopher Zimmermann [ 06/Nov/13 ]

Changed WrapLegacyModuleUIAsMagnoliaAppTask to only add icon or label properties if the provided values were not blank.

For the legacy apps logViewer, configInfo, export, import, jcrQuery, devTools, permissions:

Changed AdminModuleVersionHandler#getExtraInstallTasks
to provide blank labels and icons.

Added update tasks to remove the labels and icons from the configuration.

Comment by Christoph Meier [ 07/Nov/13 ]

review:
=> simplify WrapLegacyModuleUIAsMagnoliaAppTask (L. 117)
beside that, looks good for me

Generated at Sun Feb 11 23:08:57 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.