[MGNLAPPSW-2] Integrate app switcher into community edition Created: 26/Aug/16  Updated: 09/Feb/17  Resolved: 20/Oct/16

Status: Closed
Project: App Switcher
Component/s: None
Affects Version/s: None
Fix Version/s: 1.3

Type: Task Priority: Neutral
Reporter: Michael Mühlebach Assignee: Ngoc Nguyenthanh
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 5d
Original Estimate: 3d

Issue Links:
dependency
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Release notes required:
Yes
Documentation update required:
Yes
Date of First Response:
Sprint: Saigon 63
Story Points: 5

 Description   
Forge App Switcher Info
Moving App Switcher from Forge to CE
  • Keep the old version at Forge as it is.
  • Clone the repository as a new module of Modules category
Actions
  • Request to create Jira, git repository, hudson build for App Switcher module in Modules Git Project Category
    • Suggested name: MGNLAPPSWITCH
  • Integrate the module into CE
    • Modify the pom file of the module: change parent pom, issuesManagement, scm links, etc. The version should be: 1.3-SNAPSHOT
    • Add the dependency of the new module into CE.
  • Create a follow up ticket to create UI tests if needed.
  • After new Jira has been created. Create tickets:
    • Port App Switcher to Java 8
    • Create Unit testing
    • Bug fixings, etc
CONCERNS
  • Should we keep the old JIRA?


 Comments   
Comment by Aleksandr Pchelintcev [ 31/Aug/16 ]

there are still several things to be done before this ticket should be considered:

  • appswitcher's code base needs some grooming: currently the code is ready for Java 8 but doesn't use it to stay compatible w/ 5.4
    • a good probable strategy: old version stays at Forge as is, the new community module is fully ported to Java 8
  • appswitcher brings in another jquery plugin: https://github.com/jeresig/jquery.hotkeys It seems to be a cool one and we might even benefit from it in future, but still.
  • some bugs to sort out:
    • monkey-testing the shortcut might lead the switcher on when buttons are released
    • shortcut configurability is to be tested
  • would be really neat to have some unit/UI tests
Comment by Milan Divilek [ 19/Oct/16 ]

I have to reopen this one:
We should not move appswitcher manually from forge repo. We should move it from forge repo and keep commit history from there. Right now we have one big commit ...

MGNLCE-55 Move source code from Forge repository and fix bugs
* Fix hanging app switcher when the user switches too quickly.
* Support to config the shortcut.
* The second key of the shortcut is able to use to iterate over running apps.

How should I know from it what was needed for "Fix hanging app switcher when the user switches too quickly."?

This ticket should be in APPSWITCHER project not in MGNLCE

APPSWITCHER project has still category: Magnolia Forge

Comment by Aleksandr Pchelintcev [ 20/Oct/16 ]

mdivilek it's been agreed that the old version of the component (compatible with versions, less than 5.5) will remain on Forge, so that people can still use it with 5.4/5.3. There's a new MGNLAPPSW project created for the community module and will contain the issues for versions that we officially support. Regarding the code base, technically I agree - sure the history should've been ideally preserved, but in this case, can't we just consider this as a clean-cut after my sloppy weekend hacks with the component and not make this story too complicated?

Comment by Milan Divilek [ 20/Oct/16 ]

History preserved, ticket moved to correct jira project. Ticket closed.

Generated at Sun Feb 11 23:22:05 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.