[MGNLBACKUP-118] Don't allow relative paths in the Backup app Created: 11/Jan/18 Updated: 29/Mar/22 Resolved: 23/Feb/18 |
|
| Status: | Closed |
| Project: | Backup |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 2.2.2 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Maxime Michel | Assignee: | Saimir Gasa |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Documentation update required: |
Yes
|
| Sprint: | Basel 133, Basel 134, Basel 135 |
| Story Points: | 3 |
| Team: |
| Description |
|
When ran locally, the backup ends ends up in Tomcat's bin folder if the path is relative. On OS X the backup will be created but the user will not find it, on Linux the permissions will be missing. So it would be good to enforce an absolute path, and to also check for write permissions while we're at it. The check must be done in BackupExecutor and replicated in BackupPresenter (because the scheduled task configuration of the Backup app doesn't hit the executor directly). |
| Comments |
| Comment by Maxime Michel [ 16/Feb/18 ] |
|
As discussed with sgasa, the optional permission check described in the ticket is more complex than it sounds like when it comes to implementing it. It is not going to be done and there won't be a follow-up for it. |