[MGNLBACKUP-142] RepositoryManager should be injected into BackupExecutor Created: 20/Apr/21  Updated: 20/Jul/22  Resolved: 22/Apr/21

Status: Closed
Project: Backup
Component/s: None
Affects Version/s: 2.4.1
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Richard Gange Assignee: Unassigned
Resolution: Workaround exists Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLBACKUP-129 Backup on running instance can corrup... Closed
is related to MAGNOLIA-8069 RepositoryManager should be a system ... Closed
is related to MAGNOLIA-8070 JackRabbit specific RepositoryManager Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Epic Link: Nucleus Quality Maintenance
Team: Nucleus

 Description   

The current backup module is a JackRabbit specific implementation based on the org.apache.jackrabbit.core.RepositoryCopier. Currently this module is creating both the RepositoryConfig and RepositoryImpl objects each time the backup is run (see MGNLBACKUP-129). Instead there should be a JackRabbit specific RepositoryManager (see MAGNOLIA-8070) injected into the BackupExecutor which can call methods JackRabbitRepositoryManager#getRepositoryConfig() and JackRabbitRepositoryManager#getRepositoryImpl() to avoid having to call RepositoryConfig.create() and RepositoryImpl.create() and triggering the unnecessary overhead that comes with doing that. (see MGNLBACKUP-140 https://jira.magnolia-cms.com/secure/attachment/78392/backup-index-report-v2.4.2-SNAPSHOT.txt)



 Comments   
Comment by Richard Gange [ 22/Apr/21 ]
public BackupExecutor(BackupOperationConfiguration backupConfiguration) {
    this.backupConfiguration = backupConfiguration;
    this.repositoryManager = Components.getComponent(RepositoryManager.class);
}
Generated at Sun Feb 11 23:26:02 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.