[MGNLBACKUP-93] Use Provider to obtain schedulerModule Created: 18/May/15 Updated: 29/Mar/22 Resolved: 18/May/15 |
|
| Status: | Closed |
| Project: | Backup |
| Component/s: | None |
| Affects Version/s: | 1.5.3 |
| Fix Version/s: | 1.5.4 |
| Type: | Task | Priority: | Neutral |
| Reporter: | Espen Jervidalo | Assignee: | Espen Jervidalo |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoR: |
Empty
|
||||||||
| Date of First Response: | |||||||||
| Team: | |||||||||
| Description |
|
And while at it, remove the BackupModule.getInstance() too |
| Comments |
| Comment by Roman Kovařík [ 20/May/15 ] |
|
Please create a branch for 1.5.x without this ticket and raise to new major version on master. |
| Comment by Philip Mundt [ 20/May/15 ] |
|
Using injection for the scheduler module class could still be "compatible" with minor version bumb when maintaining the old ctor such as
@Deprecated
public BackupModule() {
this.schedulerModule = new Provider<SchedulerModule>() {
@Override
public SchedulerModule get() {
return Components.getComponent(SchedulerModule.class);
}
};
}
|
| Comment by Espen Jervidalo [ 20/May/15 ] |
|
added the deprecated constructor |
| Comment by Philip Mundt [ 26/May/15 ] |
|
Also adding deprecated constructor to BackupCommand and setting dependency to magnolia-module-scheduler back to version 1.5.1. |