New cache tools (MGNLCACHE-84)

[MGNLCACHE-22] Migrate cache tools page to new UI Created: 15/Oct/13  Updated: 02/Dec/15  Resolved: 05/Mar/15

Status: Closed
Project: Cache Modules
Component/s: cache tools
Affects Version/s: None
Fix Version/s: 5.4

Type: Sub-task Priority: Neutral
Reporter: Roman Kovařík Assignee: Milan Divilek
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Screen Shot 2014-12-02 at 13.41.12.png    
Issue Links:
Relates
relates to MGNLUI-3695 Incorporate WorkspaceSelectField(Defi... Closed
Template:
Release notes required:
Yes
Date of First Response:

 Description   
  • create new app
  • remove obsolete page
  • optionally provide statistic informations


 Comments   
Comment by Jaroslav Simak [ 02/Dec/14 ]

https://git.magnolia-cms.com/gitweb/?p=modules/cache.git;a=shortlog;h=refs/heads/MGNLCACHE-22

Comment by Jan Haderka [ 08/Dec/14 ]
  • CacheToolsPresenter - do not instantiate commands directly (e.g. in flushAllCaches() method, but same issue in all other methods), but obtain them from Commands manager so that anyone can still reconfigure them. Coming to think of it, why are those methods even in the Presenter instead of buttons invoking {{CommandAction}}s for given commands?
  • since we expect changes in configuration of cache to be implemented for 5.4 version of cache it is quite likely that parts where you read different caches from configuration will break after merging other tickets for 5.4, so as such there should be UI test to verify that it still works.
  • While you are at it, it would be nice to also provide czech i18n
Comment by Roman Kovařík [ 10/Dec/14 ]

Please add task to remove obsolete Cache Tools Page and drop dependency to legacy interface as part of this ticket.

Comment by Jaroslav Simak [ 29/Dec/14 ]

https://git.magnolia-cms.com/gitweb/?p=modules/cache.git;a=commit;h=359450ae9e666419f72091155516c54b12e5b6c7

Comment by Jan Haderka [ 29/Dec/14 ]

You are still not removing obsolete cache page from /modules/cache/pages/cachePage but just trying to remove old page from the menu which was done already for 5.2.1 iirc

Comment by Jaroslav Simak [ 29/Dec/14 ]

Yeah, delta 5.2.1 was added by me, i don't know why i set that particular version instead of 5.4 ..

Comment by Jaroslav Simak [ 29/Dec/14 ]

https://git.magnolia-cms.com/gitweb/?p=modules/cache.git;a=commit;h=a1a0fd4f2c8f7d2a5b3ac2eb51352b7e07173916

Comment by Jan Haderka [ 29/Dec/14 ]

Shouldn't u remove pages node too if it end up being empty after removal of child node?

Comment by Jaroslav Simak [ 30/Dec/14 ]

https://git.magnolia-cms.com/gitweb/?p=modules/cache.git;a=commit;h=c431befd3814917490e31ca98109f1b56f96d039

Comment by Jan Haderka [ 30/Dec/14 ]

When integrating, pls fix issue key in commit message, currently it's "MGNLKCACHE-22" instead of "MGNLCACHE-22".

Comment by Evzen Fochr [ 23/Feb/15 ]

New cache is shown in Cache information but not in Flush cache by name selector.

Comment by Magnolia International [ 04/Mar/15 ]

This introduces a call to DeltaBuilder.checkPrecondition() which leads to this log message:

[INFO] [talledLocalContainer] 2015-03-04 15:19:51,003 WARN  info.magnolia.module.InstallContextImpl           : > Updating to 5.4 is only supported from 5.1 or higher.

Reopening this issue because:
1) the message is entirely too discrete - it's almost "invisible" between the "magnolia needs update" banner and the following line that says Install could not be performed. Please check your logs and fix the appropriate issues before trying again.
2) the message seems to indicate this is about Magnolia itself (e.g core); it should be very clear that it's only about the cache module.
3) this needs to be in the release notes (checkbox)

Comment by Jaroslav Simak [ 05/Mar/15 ]

https://git.magnolia-cms.com/gitweb/?p=modules/cache.git;a=shortlog;h=refs/heads/MGNLCACHE-22_2

Comment by Milan Divilek [ 05/Mar/15 ]

Reopen: There's no need to add update precondition for version 5.1 when we are removing old page app (cacheTool). It's enough remove update task which manipulate with the old page app (cacheTool) when we're removing the page app (cacheTool) later.

Generated at Sun Feb 11 23:51:26 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.