[MGNLCACHE-57] Avoid unnecessary cache locking for uncacheable entries Created: 16/May/14 Updated: 03/Feb/16 Resolved: 29/Oct/14 |
|
| Status: | Closed |
| Project: | Cache Modules |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.3 |
| Type: | Improvement | Priority: | Major |
| Reporter: | Magnolia International | Assignee: | Roman Kovařík |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||
| Release notes required: |
Yes
|
||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||
| Description |
|
Currently, "header negotiation" lets page components set Cache* headers, which in turns sets the TTL of a cache entry to 0. The Store CacheExecutor then sees this, "replays" the cache entry immediately and discards it (rather than putting it in the cache and letting the useCache executor handle it) While implementing |
| Comments |
| Comment by Magnolia International [ 16/May/14 ] |
|
Revise |
| Comment by Magnolia International [ 25/Jul/14 ] |
|
TODO: evaluate: hit-rates can be messed up this feature as implemented in |
| Comment by Roman Kovařík [ 08/Oct/14 ] |
|
| Comment by Magnolia International [ 09/Oct/14 ] |
|
Looks good. Couple of comments on UncacheableEntry:
Good call on making |
| Comment by Roman Kovařík [ 10/Oct/14 ] |
I realised that we actually need these methods when fixing
Please see the last commit. |
| Comment by Roman Kovařík [ 13/Oct/14 ] |
Should we introduce e.g. X-Magnolia-Cache header to be able use it independently from browser caching? |
| Comment by Roman Kovařík [ 27/Oct/14 ] |
|
rename 'isUncacheableVoters' to positive 'isCacheableVoters' |
| Comment by Roman Kovařík [ 29/Oct/14 ] |
|
Review by architects:
|
| Comment by Roman Kovařík [ 29/Oct/14 ] |
|
| Comment by Roman Kovařík [ 06/Nov/14 ] |
|
isCacheableVoters moved back to Store |