[MGNLCACHE-75] Make it possible to share default configuration between multiple caches Created: 12/Sep/14 Updated: 23/Feb/15 Resolved: 16/Feb/15 |
|
| Status: | Closed |
| Project: | Cache Modules |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.4 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Stefan Baur | Assignee: | Roman Kovařík |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||
| Description |
|
Hi Currently, info.magnolia.module.cache.filter.CacheFilter#onCacheModuleStart uses cacheConfigurationName to read the cache configuration and to create the cache. This means that you force the usage of a different cache per cache filter. If you have to setup multi site caching (https://documentation.magnolia-cms.com/display/DOCS/Advanced+Cache+module#AdvancedCachemodule-Multisitecacheconfiguration), you will end up with N cache filters and N cache configurations. Maybe a second property cacheName on the filter will do the magic. And you can always fallback to cacheConfigurationName if cacheName is not set. Cheers, |
| Comments |
| Comment by Magnolia International [ 15/Sep/14 ] |
|
Hey Stefan, Thanks for the idea. This doesn't solve your problem
I'd suggest the following:
|
| Comment by Stefan Baur [ 15/Sep/14 ] |
|
Hi Greg.
Does this mean that this class should already exist in the current release, or is already prepared for to be released with 5.4, or could be released in the future? Since yesterday, I have also noticed that the 1:1 mapping between cache configuration and cache (=Ehcache) instance is also implicitly made in other places. This seems to happen in
Cheers, |
| Comment by Magnolia International [ 15/Sep/14 ] |
|
I meant that Advanced Cache should provide such a filter in a future release Ho and thanks for this name/config mapping analysis, it's actually quite helpful ! I fixed a couple of these places, but possibly not all ! |
| Comment by Stefan Baur [ 17/Oct/14 ] |
|
Good morning. Do you have any news about
Cheers, |
| Comment by Jan Haderka [ 09/Dec/14 ] |
|
Hi Stefan, yes we still plan to implement this feature for Magnolia 5.4. The release date is plan for around end of March 2015. |
| Comment by Jan Haderka [ 15/Feb/15 ] |
|
AbstractListeningFlushPolicy
CacheFactory
|