[MGNLCACHE-78] Move store caching configuration into cachePolicy Created: 27/Oct/14  Updated: 19/Feb/15  Resolved: 16/Feb/15

Status: Closed
Project: Cache Modules
Component/s: None
Affects Version/s: None
Fix Version/s: 5.4

Type: Improvement Priority: Neutral
Reporter: Roman Kovařík Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: m2
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
depends upon MGNLCACHE-55 Caching arbitrary objects Closed
is depended upon by MGNLPN-186 Update cache-related update tasks to ... Closed
relation
is related to MGNLCACHE-57 Avoid unnecessary cache locking for u... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

MGNLCACHE-57 introduced isCacheableVoters configuration under Default cache policy to have all cache voters at one place:

  1. Move this configuration to CachePolicy interface next to the voters for bypass. I'd also suggest to make it more powerful than just cacheable/noncacheable. I could return TTL and the logic from info.magnolia.module.cache.executor.Store#getTimeToLive should go there.
  2. Rename CachePolicy/voters to something more explanatory (bypass/shouldBypass).
  3. -Move also other configuration there that's spread across other places (e.g Store also has a compressible configuration item)- this is no longer the case


 Comments   
Comment by Magnolia International [ 28/Oct/14 ]

If we do this, I'd suggest we consider also moving other configuration that's spread across other places (e.g Store also has a compressible configuration item)

Comment by Roman Kovařík [ 02/Feb/15 ]

Integrated.

Comment by Roman Kovařík [ 09/Feb/15 ]

Reopen: minor thing: TtlVoting could finish if lowestTtl=0.

Generated at Sun Feb 11 23:51:59 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.