[MGNLCAMPU-17] Public instance installation is corrupted upon including unpublished parents for config and publishing Created: 02/Apr/15 Updated: 05/May/15 Resolved: 04/May/15 |
|
| Status: | Closed |
| Project: | Campaign Publisher |
| Component/s: | None |
| Affects Version/s: | 1.0 |
| Fix Version/s: | 1.0 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Jan Haderka | Assignee: | Roman Kovařík |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
What happens is that /modules and /modules/some-module nodes get included in publishing and that just kills it. |
| Comments |
| Comment by Jan Haderka [ 13/Apr/15 ] |
|
How/where is this fixed? there's no code linked to this issue (at least none that can be seen by jira/git). And IIRC we said it should be fixed in activation rather than here anyway. |
| Comment by Evzen Fochr [ 14/Apr/15 ] |
|
I just deleted branch, forgot to reopen it |
| Comment by Roman Kovařík [ 04/May/15 ] |
|
Condition for skipping config node on 1st and 2nd level is not readable: + if (targetNode.getDepth() > 1 && !NodeTypes.Activatable.isActivated(targetNode.getParent()) && !StringUtils.contains(commandName, "workflow") //) { // when workf + && (!RepositoryConstants.CONFIG.equals(wksName) || targetNode.getDepth() < 3)) { //config nodes on 1st and 2nd level don't have to be activated targetNode.getDepth() < 3 should become targetNode.getParent().getDepth() < 2 |