[MGNLCAMPU-18] Unpublish campaign action shows warning about publishing unreviewed items. Created: 02/Apr/15 Updated: 30/Apr/15 Resolved: 13/Apr/15 |
|
| Status: | Closed |
| Project: | Campaign Publisher |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.0 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Jan Haderka | Assignee: | Evzen Fochr |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Description |
|
First I think warning is irrelevant, but even if we keep it, it should refer to unpublishing instead, shouldn't it? |
| Comments |
| Comment by Jan Haderka [ 13/Apr/15 ] |
|
If you are using inner class for definition why not to call it just Definition? There is no longer point in duplicating name of the action in definition name and ending up w/ something as ugly as UnpublishCampaignAction.UnpublishCampaignActionDefinition. Having UnpublishCampaignAction.Definition is just so much nicer and more concise. |