[MGNLCAMPU-3] Add action to refresh dependencies Created: 26/Feb/15 Updated: 30/Mar/15 Resolved: 18/Mar/15 |
|
| Status: | Closed |
| Project: | Campaign Publisher |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.0 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Jan Haderka | Assignee: | Jaroslav Simak |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Date of First Response: |
| Description |
|
to add new ones and removed those no longer referenced from any pages (unless added directly) |
| Comments |
| Comment by Evzen Fochr [ 17/Mar/15 ] |
|
Confirmation button in dialog window should be named like add or ok. (campaign-manager.confirmationDialog.confirm.label = Refresh) |
| Comment by Jaroslav Simak [ 17/Mar/15 ] |
|
I don't see any reason why, action is called refresh dependencies, thus button in the confirmation dialog says also refresh. This action is not only about adding new dependencies, but also about removing non-existing (old) ones, so add label cannot be used here. |
| Comment by Evzen Fochr [ 17/Mar/15 ] |
|
What about "Confirm" ? |
| Comment by Jaroslav Simak [ 17/Mar/15 ] |
|
I don't think that confirm should be used here. Imho button label should tell user what it actually does, in this case, it refreshes deps. If you take a look for example at pages app, and try to delete a page, it says yes, delete. I find this better from the ux perspective than buttons labeled like ok or confirm. |
| Comment by Evzen Fochr [ 17/Mar/15 ] |
|
From my point of view it is confirmation of changes that are suggested by refresh dependencies action, but "refresh" evoke that another refresh action will be started. |
| Comment by Jaroslav Simak [ 17/Mar/15 ] |
|
Refresh just says, what it will do, when you click the button. Like in the pages app example. |
| Comment by Evzen Fochr [ 17/Mar/15 ] |
|
In pages app delete dialog you have text "Delete this item ?" and answer is "Yes, delete", but in CM you have text in dialog "Refresh dependencies" and answer "Refresh" so if we strictly follow your example, label for confirmation button should be "Yes, refresh" (and i will be happy with this). And add ? to "Refresh dependencies?" |