[MGNLCAMPU-31] Make campaign workspace and nodeType configurable. Make merge split and publish action successMessage overridable. Created: 09/Jun/15  Updated: 08/Jul/15  Resolved: 08/Jul/15

Status: Closed
Project: Campaign Publisher
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Thanh Pham Assignee: Evzen Fochr
Resolution: Obsolete Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File campaign-publisher-eclipse.patch     Text File campaign-publisher-git.patch    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

SelectCampaignFieldDefinition: make workspace and nodeType as configurable fields
ItemReadyColumnFormatter: make nodeType as configurable field
CampaignTargetColumnFormatter: add the empty trash icon for deleted node ( has mark as delete status )
SplitCampaignAction: make the message can override
MergeCampaignAction: make the message can override
PublishCampaignCommand: make nodeType as configurable field



 Comments   
Comment by Jaroslav Simak [ 15/Jun/15 ]

thanh.pham why do you need custom node types? What is the usecase please?

Comment by Thanh Pham [ 16/Jun/15 ]

jsimak
1/ Change container: A mechanism to bundle changes on content, assets, JS/CSS/FTL and configuration in a joint context. Change container allows to transfer, merge and publish changes in an bundled manner.  This module based on the POC of campaign manager ( now it is campaign publisher )
2/ We have some features, actions duplicate with the campaign publisher ( i.e: add to change container action, split, merge,...)
and a lot of extra features like: push change container to other author instances, push message, merge override, merge tool, versioning,...
• In last development, i copied code from campaign publisher to modified it for my module but it made the code duplicate. 
• Now, we want to optimize code and remove duplicate code.
3/ By the way, I create a new node type ( mgnl:changeContainer ) because i need to store a lot of extra infors ( version name, receive by author, merge status, … ) so that i can make my module integrate with data transfer, advanced versioning, merge tool,… in my project.

Comment by Jan Haderka [ 16/Jun/15 ]

Why can't you store those extra properties in existing node type? There are no restrictions to that.
If you want to have extra properties typed, you should use mixin over existing node type instead of changing it completely.

Comment by Thanh Pham [ 08/Jul/15 ]

@all: we use campaign app directly and move all new features of change container module to campaign app. Now, this ticket is invalid.

Generated at Sun Feb 11 23:56:46 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.