[MGNLCAMPU-76] Dependency on personalization in not optional Created: 22/Nov/19  Updated: 26/Aug/22

Status: Open
Project: Campaign Publisher
Component/s: None
Affects Version/s: 1.3.1
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Viet Nguyen Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: maintenance
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File maven-pom-dependency.png     PNG File module-descriptor-dependency.png    
Issue Links:
Relates
relates to MSITEMESH-55 Dependency on personalization should ... Open
causality
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: AuthorX Support
Team: AuthorX

 Description   

We are seeing that we made use of "personalization-integration" however from Maven artifact dependency we don't have any coding reference to it, see below image:

A draft investigation shown that we're using few of info.magnolia.personalization.action.IsNoVariantRule in some configuration points such as /modules/campaign-publisher/apps/campaigns/subApps/browser/actions/markReady/availability/rules/IsNoVariantRule

Decouple these modules improve the "high cohesion and low coupling" of system.

In module descriptor, personalization-integration is defined as a required dependency, not optional so this should be a logic bug from Magnolia development point of view, dependencies of bootstrapping only need to be listed as optional dependencies so that customer can remove the dependent modules in case they are not use it. Definition point in module descriptor here:


Generated at Sun Feb 11 23:57:11 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.