[MGNLCAT-6] Bundle is wrong Created: 05/Jun/09  Updated: 04/Oct/13  Resolved: 04/Aug/09

Status: Closed
Project: Magnolia Categorization Module
Component/s: None
Affects Version/s: 1.0
Fix Version/s: 1.0.1

Type: Task Priority: Major
Reporter: Magnolia International Assignee: Teresa Miyar
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

The module currently produces a bundle (is this even needed?) which is most likely wrong / contains way too many unneeded jars:

$ unzip -l  magnolia-module-categorization-1.0-rc1-bundle.zip
Archive:  magnolia-module-categorization-1.0-rc1-bundle.zip
  Length     Date   Time    Name
 --------    ----   ----    ----
        0  06-03-09 20:45   magnolia-module-categorization-1.0-rc1/
      413  06-03-09 20:45   magnolia-module-categorization-1.0-rc1/LICENSE.txt
     3002  06-03-09 20:45   magnolia-module-categorization-1.0-rc1/NOTICE.txt
      365  06-03-09 20:45   magnolia-module-categorization-1.0-rc1/README.txt
   104877  06-02-09 23:34   magnolia-module-categorization-1.0-rc1/magnolia-module-data-1.3.1.jar
    13713  03-10-09 13:46   magnolia-module-categorization-1.0-rc1/magnolia-module-scheduler-1.3.jar
   388716  07-03-08 16:18   magnolia-module-categorization-1.0-rc1/quartz-1.5.2.jar
    62246  07-03-08 16:15   magnolia-module-categorization-1.0-rc1/json-lib-0.9.jar
   431568  07-03-08 16:18   magnolia-module-categorization-1.0-rc1/xom-1.1.jar
    60097  07-03-08 16:15   magnolia-module-categorization-1.0-rc1/ezmorph-0.8.1.jar
   139462  06-03-09 19:08   magnolia-module-categorization-1.0-rc1/magnolia-module-rssaggregator-1.0-rc1.jar
   218750  02-24-09 11:45   magnolia-module-categorization-1.0-rc1/rome-1.0RC2.jar
    29675  02-24-09 11:45   magnolia-module-categorization-1.0-rc1/rome-fetcher-1.0RC2.jar
    26202  07-03-08 16:51   magnolia-module-categorization-1.0-rc1/commons-logging-api-1.0.4.jar
    25752  06-03-09 18:58   magnolia-module-categorization-1.0-rc1/magnolia-module-observation-1.1-rc1.jar
   787052  06-03-09 20:35   magnolia-module-categorization-1.0-rc1/magnolia-module-standard-templating-kit-1.1-rc1.jar
    26102  06-03-09 02:54   magnolia-module-categorization-1.0-rc1/magnolia-module-inplace-templating-1.0.1.jar
    28627  06-03-09 02:51   magnolia-module-categorization-1.0-rc1/magnolia-module-resources-1.1-rc1.jar
    55481  06-03-09 03:04   magnolia-module-categorization-1.0-rc1/magnolia-module-form-1.0.1.jar
   143223  06-03-09 18:00   magnolia-module-categorization-1.0-rc1/magnolia-module-forum-1.0-rc1.jar
   188671  07-03-08 16:05   magnolia-module-categorization-1.0-rc1/commons-beanutils-1.7.0.jar
    73169  12-17-08 18:04   magnolia-module-categorization-1.0-rc1/commons-proxy-1.0.jar
   307930  12-17-08 18:04   magnolia-module-categorization-1.0-rc1/cglib-full-2.0.2.jar
  6591447  06-03-09 20:37   magnolia-module-categorization-1.0-rc1/magnolia-demo-project-1.1-rc1.jar
   111755  06-03-09 20:37   magnolia-module-categorization-1.0-rc1/magnolia-theme-pop-1.1-rc1.jar
    71085  06-03-09 20:45   magnolia-module-categorization-1.0-rc1/magnolia-module-categorization-1.0-rc1.jar
 --------                   -------
  9889380                   26 files


 Comments   
Comment by Magnolia International [ 10/Jun/09 ]

This is the status for rc2:

$ unzip -l ~/Downloads/magnolia-module-categorization-1.0-rc2-bundle.zip 
Archive:  /Users/gjoseph/Downloads/magnolia-module-categorization-1.0-rc2-bundle.zip
  Length     Date   Time    Name
 --------    ----   ----    ----
        0  06-10-09 15:48   magnolia-module-categorization-1.0-rc2/
   104809  06-10-09 15:42   magnolia-module-categorization-1.0-rc2/magnolia-module-data-1.3.2.jar
    13713  06-10-09 15:42   magnolia-module-categorization-1.0-rc2/magnolia-module-scheduler-1.3.jar
   388716  06-10-09 15:42   magnolia-module-categorization-1.0-rc2/quartz-1.5.2.jar
   139420  06-10-09 15:42   magnolia-module-categorization-1.0-rc2/magnolia-module-rssaggregator-1.0-rc2.jar
   218750  06-05-09 02:16   magnolia-module-categorization-1.0-rc2/rome-1.0RC2.jar
    29675  06-05-09 02:16   magnolia-module-categorization-1.0-rc2/rome-fetcher-1.0RC2.jar
    25752  06-10-09 15:01   magnolia-module-categorization-1.0-rc2/magnolia-module-observation-1.1-rc1.jar
   791236  06-10-09 15:36   magnolia-module-categorization-1.0-rc2/magnolia-module-standard-templating-kit-1.1-rc3.jar
    26102  06-10-09 15:42   magnolia-module-categorization-1.0-rc2/magnolia-module-inplace-templating-1.0.1.jar
    28627  06-10-09 15:42   magnolia-module-categorization-1.0-rc2/magnolia-module-resources-1.1-rc1.jar
    55481  06-10-09 15:42   magnolia-module-categorization-1.0-rc2/magnolia-module-form-1.0.1.jar
   143223  06-10-09 15:42   magnolia-module-categorization-1.0-rc2/magnolia-module-forum-1.0-rc1.jar
  6601237  06-10-09 15:40   magnolia-module-categorization-1.0-rc2/magnolia-demo-project-1.1-rc3.jar
   114310  06-10-09 15:38   magnolia-module-categorization-1.0-rc2/magnolia-theme-pop-1.1-rc3.jar
    71069  06-10-09 15:48   magnolia-module-categorization-1.0-rc2/magnolia-module-categorization-1.0-rc2.jar
      413  06-10-09 15:48   magnolia-module-categorization-1.0-rc2/LICENSE.txt
     2227  06-10-09 15:48   magnolia-module-categorization-1.0-rc2/NOTICE.txt
      365  06-10-09 15:48   magnolia-module-categorization-1.0-rc2/README.txt
 --------                   -------
  8755125                   19 files

Still too many unnecessary jars, and still no answer to "do we really need a bundle for this module" ?

Comment by Teresa Miyar [ 11/Jun/09 ]

I think there is no need for a bundle as is provided with etk and won't work without it. I guess dependencies could be 'provided'

Comment by Magnolia International [ 03/Aug/09 ]

If no bundle is needed at all, you can remove the assembly plugin from the pom.
However, it is still good to mark dependencies as provided. We also need to mark some as optional. ie: the data module dependency, despite being "provided" is mandatory, while the dependency to stk or rss is probably optional as well.

Comment by Teresa Miyar [ 04/Aug/09 ]

In this case data and stk are mandatory

Generated at Mon Feb 12 04:42:11 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.