- Update tasks for removing label/icon from the delete action both check for existence of the icon property, they also both have icon in their description. One should be for label, one for icon.
- Both action bar mappings update tasks don't check for existence of the node to be renamed itself, but only the parent actionbar node.
- Don't need action.setProperty("label", "New category") in:
- testUpdateTo202RemovesDeleteFolderAction
- testUpdateTo202RenamesDeleteCategoryNode
- in testUpdateTo202ActionbarNodesUpdated:
- folderMappings references the deleteFolder action already, not its parent items, resulting in creating deleteFolder in deleteFolder.
- typo: categoryMappings, not cate*r*goryMappings
EDIT: for second point, I had not realized it was a recursive rename task, and indeed it causes no harm if there is no match under the actionbar node.
|