[MGNLCAT-81] DeleteAction: update version handler Created: 18/Jul/13  Updated: 26/Jul/13  Resolved: 26/Jul/13

Status: Closed
Project: Magnolia Categorization Module
Component/s: None
Affects Version/s: 2.0.1
Fix Version/s: 2.0.2

Type: Task Priority: Neutral
Reporter: Espen Jervidalo Assignee: Espen Jervidalo
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

related to MGNLCAT-80



 Comments   
Comment by Mikaël Geljić [ 25/Jul/13 ]
  • Update tasks for removing label/icon from the delete action both check for existence of the icon property, they also both have icon in their description. One should be for label, one for icon.
  • Both action bar mappings update tasks don't check for existence of the node to be renamed itself, but only the parent actionbar node.
  • Don't need action.setProperty("label", "New category") in:
    • testUpdateTo202RemovesDeleteFolderAction
    • testUpdateTo202RenamesDeleteCategoryNode
  • in testUpdateTo202ActionbarNodesUpdated:
    • folderMappings references the deleteFolder action already, not its parent items, resulting in creating deleteFolder in deleteFolder.
    • typo: categoryMappings, not cate*r*goryMappings

EDIT: for second point, I had not realized it was a recursive rename task, and indeed it causes no harm if there is no match under the actionbar node.

Generated at Mon Feb 12 04:42:55 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.