[MGNLCDEP-110] Dialog is not closed after firing LocationChangedEvent Created: 28/May/20  Updated: 08/Dec/21  Resolved: 08/Dec/21

Status: Closed
Project: Content Dependencies
Component/s: None
Affects Version/s: 2.0.1
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Jonathan Ayala Assignee: Nguyen Phung Chi
Resolution: Duplicate Votes: 0
Labels: 62-UI-3, maintenance, tech-debt, ui-ux-impr
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Screenshot 2020-05-28 at 16.34.25.png    
Issue Links:
Cloners
is cloned by MGNLUI-6170 Dialog still visible after firing Loc... Closed
Problem/Incident
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: UI framework implementation
Sprint: Global Maintenance 3
Story Points: 2

 Description   

When a dialog contains a field that redirects to another location by firing a LocationChangedEvent when clicking on it (no action buttons involved), it is not closed after redirecting to the new location and, therefore, it is not visible and not user friendly as they have to close the dialog.

This can be reproduced in the dependencies tab from content dependencies module.

Steps to reproduce in demo:

  1. Configure dependencies tab as explained in docs
  2. Go to pages app, travel/about and open the editor
  3. Click on "edit page properties" and go to dependencies tab
  4. Click on dependency /travel
  5. Dialog is not closed and redirection occurs behind

When using Magnolia 5 UI with -m5 parameter, this doesn't happen, which seems closely related to the usage of info.magnolia.ui.framework.app.DefaultAppView in UI 5 instead of info.magnolia.admincentral.AdmincentralAppView used in UI 6, which in turn, means that Magnolia class method (info.magnolia.ui.vaadin.tabsheet.MagnoliaTabSheet.setActiveTab(MagnoliaTab)) is called in 5 UI whereas Vaadin class method ((com.vaadin.ui.TabSheet.setSelected(Component)) is called in 6 UI. There should be a way to close the dialog in the new UI.


Generated at Mon Feb 12 00:12:38 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.