[MGNLCDEP-74] Warn on deletion of page with modified children Created: 04/Nov/14  Updated: 18/Dec/14  Resolved: 18/Dec/14

Status: Closed
Project: Content Dependencies
Component/s: None
Affects Version/s: 1.1.3
Fix Version/s: 1.1.4

Type: Bug Priority: Major
Reporter: Roman Kovařík Assignee: Christopher Zimmermann
Resolution: Fixed Votes: 0
Labels: support
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
depends upon MAGNOLIA-5964 Warn on deletion of page with modifie... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Release notes required:
Yes
Date of First Response:

 Description   

Respect changes done by MAGNOLIA-5964.



 Comments   
Comment by Roman Kovařík [ 05/Nov/14 ]

[09:54] Federico Grilli:
1. .DS _Store file should be removed from git

2. is it necessary to update the dep on magnolia to the latest?

Comment by Roman Kovařík [ 05/Nov/14 ]
  1. Removed.
  2. Yes, checkIfChildrenModified() was introduced by MAGNOLIA-5964.
Comment by Christopher Zimmermann [ 18/Dec/14 ]

Reopen. When you attempt to delete a node in another tree besides the Pages app, such as a node in the Templating / Sites "app", you get a big mess of html instead of the node name.
This is being returned by the checkIfChildrenAreModified method.
Something like this:
--------------------------------------------
Delete node?
--------------------------------------------
The subnode
<div id="mgnlTreeControl_/modules/extended-templating-kit/config/sites/demo-project-de/domains/demo-project-de0/name_LineInter" class="mgnlTreeLineInter mgnlLineDisabled"></div><div id="mgnlTreeControl_/modules/extended-templating-kit/config/sites/demo-project-de/domains/demo-project-de0/name_DivMain" style="position:relative;top:0;left:0;width:100%;height:18px;"> <span id="mgnlTreeControl_/modules/extended-templating-kit/config/sites/demo-pro

Comment by Christopher Zimmermann [ 18/Dec/14 ]

Added check to deleteNode in contentDependencies.js script so that it only calls checkIfChildrenModified() if the repository is website - since this ticket is about Pages & since checkIfChildrenModified is only implemented in the WebsiteTreeHandler.

(The problem is that trees with other handlers did not have the checkIfChildrenModified command available, and so AdminTreeMVCHandler SHOW command was run by default which was just returning fragments of the tree!)

Generated at Mon Feb 12 00:12:17 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.