[MGNLCDEP-76] Allow for checking dependencies to any workspace Created: 19/Dec/14 Updated: 27/Nov/15 Resolved: 25/Aug/15 |
|
| Status: | Closed |
| Project: | Content Dependencies |
| Component/s: | None |
| Affects Version/s: | 1.4.1 |
| Fix Version/s: | 1.6 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Frank Sommer | Assignee: | Jaroslav Simak |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | requires_documentation, support | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 19d 7h | ||
| Original Estimate: | 0.5d | ||
| Attachments: |
|
||||||||||||||||
| Issue Links: |
|
||||||||||||||||
| Template: |
|
||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||
| Release notes required: |
Yes
|
||||||||||||||||
| Date of First Response: | |||||||||||||||||
| Sprint: | Sprint 2 (Vietnam), Sprint 7 (Kromeriz) | ||||||||||||||||
| Story Points: | 5 | ||||||||||||||||
| Description |
|
The contact property is configured in the dependencies module. So this property is included by the dependencies check. But the check to the contacts workspace is not yet implemented. The DefaultDependencies class checks only node identifiers for website and assets workspace. So the dependency is not shown and only a log message is written. WARN info.magnolia.module.dependencies.impl.DefaultDependencies 19.12.2014 10:56:50 -- Could not get node by identifier [a97ed3e2-23f4-4950-8aab-ecff805a4884] from [website] |
| Comments |
| Comment by Frank Sommer [ 29/Apr/15 ] |
|
Furthermore the content dependencies module should not check hard wired only against website and assets workspace. It should be configurable in the module configuration. |
| Comment by Federico Grilli [ 24/Jun/15 ] |
|
sang.ngo I'm taking a look at your solution and, being this more than a trivial bug fix, I think it would beneficial if you could write a brief concept about it. It doesn't need to be extra-detailed, just an outline of how you intend to solve the issue. Here are some guidelines and several concept pages you can look at for "inspiration" https://wiki.magnolia-cms.com/display/DEV/Concepts. If you don't feel like writing a concept proper it might also do a comment or a more elaborated issue description. Also consider that this will be likely used by our documentation team to update the module's doc. Thanks. |
| Comment by Federico Grilli [ 24/Jun/15 ] |
|
At any rate, I'm seeing lots of code duplication (e.g. DependencyService and Dependencies and their respective implementations, DependenciesField(Definition/Factory ) and ReferenceField(Definition/Factory) ). I'd try a solution which try to use the existing interfaces and classes. Also, I'd try to keep the workspace/properties configuration under the modules' config node (you can have any object in there) instead of having it nested deep in the dialog tabs config. |
| Comment by Federico Grilli [ 24/Jun/15 ] |
|
OTOH, on second thoughts, the new interfaces are cleaner and would allow to gradually remove the old Dependencies stuff in a later version. Also I like the fact that ReferenceFieldDefinition keeps all it needs to build a proper reference field whereas now this info is part under config/referenceProperties, part under dialogs/reference@referencesTo. So maybe your solution is the way to go. I'd ask quickly someone in the architect cell to validate your solution anyway. |
| Comment by Sang Ngo Huu [ 29/Jun/15 ] |
|
Add concept page for this https://wiki.magnolia-cms.com/pages/viewpage.action?pageId=104830084 fgrilli Have you asked architect guy to verify my way? |
| Comment by Philip Mundt [ 14/Jul/15 ] |
|
| Comment by Sang Ngo Huu [ 23/Jul/15 ] |
|
Branch name is
Thanks |
| Comment by Sang Ngo Huu [ 27/Jul/15 ] |
|
| Comment by Jan Haderka [ 27/Jul/15 ] |
|
Since |
| Comment by Sang Ngo Huu [ 03/Aug/15 ] |
|
The fixes on |
| Comment by Jaroslav Simak [ 19/Aug/15 ] |
|
I think this shouldn't go into a minor version as it is a complete overhaul of the Dependencies functionality/API. |
| Comment by Philip Mundt [ 25/Aug/15 ] |
Edit: add bullet points for better readability |