[MGNLCDEP-86] Investigate if dependency on DAM can be removed or not Created: 24/Aug/15 Updated: 29/Oct/15 Resolved: 29/Oct/15 |
|
| Status: | Closed |
| Project: | Content Dependencies |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Neutral |
| Reporter: | Jaroslav Simak | Assignee: | Ngoc Nguyenthanh |
| Resolution: | Not an issue | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoR: |
Empty
|
| Date of First Response: | |
| Sprint: | Saigon 16 |
| Story Points: | 2 |
| Description |
|
Dependencies module has dependency on DAM but uses only some constants defined in dam. |
| Comments |
| Comment by Ngoc Nguyenthanh [ 26/Oct/15 ] |
|
jsimak Could you please show me more reasons why we need to remove DAM dependency in this module? |
| Comment by Ngoc Nguyenthanh [ 27/Oct/15 ] |
|
This module depend on magnolia-dam-jcr ( implicit depend on magnolia-dam-api, magnolia-dam-core)
Solution: Keep the scope test or simple is remove (still pass all test case after remove on my local)
Add constants in this module, then copy values from
Create a class the same with info.magnolia.dam.api.ItemKey then replace in info.magnolia.module.dependencies.impl.DefaultDependencies Basically, we can remove the DAM dependency. But each time DAM module changes those constants or key format, the module may not work correctly and require to modify by manually. |
| Comment by Philip Mundt [ 27/Oct/15 ] |
|
I believe this issue should not be fixed! There is (and will remain) a module-descriptor dependency to DAM (due to the fact that we want to resolve dependencies from assets-to-pages, also see |
| Comment by Ngoc Nguyenthanh [ 28/Oct/15 ] |
|
pmundt I agree with you too. |
| Comment by Jaroslav Simak [ 29/Oct/15 ] |
|
pmundt ngoc.nguyenthanh I am sorry, should have used better title for the ticket. This ticket should be just about investigation if we can remove the dependency or not. I did not want the dependency to be removed in this ticket. Again, i am sorry about that. |
| Comment by Mikaël Geljić [ 29/Oct/15 ] |
|
Thanks jsimak, PS: I accidentally edited your comment saying you had edited ticket description shortly before, sorry about that! |
| Comment by Jaroslav Simak [ 29/Oct/15 ] |
|
|
| Comment by Ngoc Nguyenthanh [ 29/Oct/15 ] |
|
|