[MGNLCDEP-86] Investigate if dependency on DAM can be removed or not Created: 24/Aug/15  Updated: 29/Oct/15  Resolved: 29/Oct/15

Status: Closed
Project: Content Dependencies
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Neutral
Reporter: Jaroslav Simak Assignee: Ngoc Nguyenthanh
Resolution: Not an issue Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Sprint: Saigon 16
Story Points: 2

 Description   

Dependencies module has dependency on DAM but uses only some constants defined in dam.
Investigation if we can remove DAM dependency nor not.



 Comments   
Comment by Ngoc Nguyenthanh [ 26/Oct/15 ]

jsimak Could you please show me more reasons why we need to remove DAM dependency in this module?
Is it related to any issues?
Thanks in advance!

Comment by Ngoc Nguyenthanh [ 27/Oct/15 ]

This module depend on magnolia-dam-jcr ( implicit depend on magnolia-dam-api, magnolia-dam-core)
Classes depend on:

  • info.magnolia.dam.jcr.AssetNodeTypes
  • info.magnolia.dam.api.ItemKey
  • info.magnolia.dam.jcr.DamConstants
  • info.magnolia.dam.api.metadata.MagnoliaAssetMetadata
  • info.magnolia.dam.jcr.metadata.JcrMagnoliaAssetMetadata

Solution:

Keep the scope test or simple is remove (still pass all test case after remove on my local)
Used in info.magnolia.module.dependencies.impl.DefaultDependenciesTest

  • info.magnolia.dam.api.metadata.MagnoliaAssetMetadata
  • info.magnolia.dam.jcr.metadata.JcrMagnoliaAssetMetadata

Add constants in this module, then copy values from

  • info.magnolia.dam.jcr.AssetNodeTypes.Asset
  • info.magnolia.dam.jcr.DamConstants

Create a class the same with info.magnolia.dam.api.ItemKey then replace in info.magnolia.module.dependencies.impl.DefaultDependencies

Basically, we can remove the DAM dependency. But each time DAM module changes those constants or key format, the module may not work correctly and require to modify by manually.

Comment by Philip Mundt [ 27/Oct/15 ]

I believe this issue should not be fixed! There is (and will remain) a module-descriptor dependency to DAM (due to the fact that we want to resolve dependencies from assets-to-pages, also see MGNLCDEP-85), so why should we get rid of this dependency?

Comment by Ngoc Nguyenthanh [ 28/Oct/15 ]

pmundt I agree with you too.
Anyway, I still want to know opinion from ticket owner jsimak.

Comment by Jaroslav Simak [ 29/Oct/15 ]

pmundt ngoc.nguyenthanh I am sorry, should have used better title for the ticket. This ticket should be just about investigation if we can remove the dependency or not. I did not want the dependency to be removed in this ticket. Again, i am sorry about that.

Comment by Mikaël Geljić [ 29/Oct/15 ]

Thanks jsimak,
So, after investigation, we agree that DAM dependency cannot / should not be removed, right?
May we close it as "Not an issue" and remove fix version?

PS: I accidentally edited your comment saying you had edited ticket description shortly before, sorry about that!

Comment by Jaroslav Simak [ 29/Oct/15 ]

Comment by Ngoc Nguyenthanh [ 29/Oct/15 ]

Generated at Mon Feb 12 00:12:24 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.