[MGNLCE-135] Align the log4j2.xml config with the new Publishing module Created: 10/Jan/18 Updated: 16/Apr/20 Resolved: 23/Apr/18 |
|
| Status: | Closed |
| Project: | Community Edition |
| Component/s: | None |
| Affects Version/s: | 5.6, 5.6.1 |
| Fix Version/s: | 5.6.6, 5.7 |
| Type: | Task | Priority: | Neutral |
| Reporter: | Martin Drápela | Assignee: | Robert Šiška |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||
| Issue Links: |
|
||||
| Template: |
|
||||
| Acceptance criteria: |
Empty
|
||||
| Task DoR: |
Empty
|
||||
| Documentation update required: |
Yes
|
||||
| Date of First Response: | |||||
| Sprint: | Kromeriz 143, Kromeriz 144 | ||||
| Story Points: | 3 | ||||
| Description |
|
1) After the release of 5.6, the Logger configuration for Publishing (Activation) in log4j2.xml is still outdated: <!-- Activation - additivity is true so logs also go to sub-categories' appenders -->
<Logger name="info.magnolia.cms.exchange" level="INFO" additivity="true">
<AppenderRef ref="log-activation"/>
</Logger>
<Logger name="info.magnolia.module.activation" level="INFO" additivity="true">
<AppenderRef ref="log-activation"/>
</Logger>
2) Also consider renaming all "activation" values to "publishing", see above and also e.g. in this section of the config file: <RollingFile name="sync-log-activation"
fileName="${magnolia.logs.dir}/magnolia-activation.log"
filePattern="${magnolia.logs.dir}/magnolia-activation-%i.log"
append="true">
<PatternLayout pattern="%-5p %c %d{dd.MM.yyyy HH:mm:ss} -- %m%n"/>
<ThresholdFilter level="ERROR"/>
<Policies>
<SizeBasedTriggeringPolicy size="1MB"/>
</Policies>
<DefaultRolloverStrategy max="5"/>
</RollingFile>
<Async name="log-activation">
<AppenderRef ref="sync-log-activation"/>
</Async>
3) When closing the ticket, please guide the DOC team in what needs to be updated on |
| Comments |
| Comment by Roman Kovařík [ 19/Apr/18 ] |
|
Reopened:
|
| Comment by Jaroslav Simak [ 20/Apr/18 ] |
|
Reopened. There must be something wrong with the log4j2 config, because level INFO isn't log for publishing requests at all. |
| Comment by Robert Šiška [ 20/Apr/18 ] |
|
In our bundles we set Threshold Filter of log-publishing to ERROR - that means that it will only log ERROR & FATAL. This behaviour wasn't introduced by this commit, so I don't see any reason for reopen. |
| Comment by Jaroslav Simak [ 20/Apr/18 ] |
|
True, but i mean that there's no INFO statements for publishing in console, before this, there were always message about what is being published and whether the publication succeeded. |
| Comment by Robert Šiška [ 23/Apr/18 ] |
|
After investigating bit more, it seems that publishing module doesn't actually produce any INFO messages. After modifying the code to throw some, it did log them correctly.
I guess we can close this ticket and create an follow-up for publishing module to adjust log levels. |