[MGNLCE-218] Two different swagger versions Created: 13/Mar/20  Updated: 20/Mar/20  Resolved: 18/Mar/20

Status: Closed
Project: Community Edition
Component/s: None
Affects Version/s: None
Fix Version/s: 6.2

Type: Improvement Priority: Neutral
Reporter: Quach Hao Thien Assignee: Quach Hao Thien
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 5.5h
Original Estimate: Not Specified

Issue Links:
Cloners
clones BUILD-374 Two different swagger versions Closed
Relates
relates to BUILD-374 Two different swagger versions Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Epic Link: Library updates 6.2
Sprint: 6.2 Ramp-up 19, 6.2 Ramp-up 20
Story Points: 0

 Description   

We already have an exclusion, for swagger-annotations, but in rest-tools module we have also swagger-core and swagger-models. Can be good investigate in possible problems or finally try to keep just one swagger library version in magnolia

If you add rest-tools as dependency in https://git.magnolia-cms.com/projects/PLATFORM/repos/ce/browse/magnolia-community-webapp/pom.xml then you get a compilation error:

collision: [swagger-core-2.0.9.jar, swagger-core-1.5.22.jar]
collision: [swagger-models-2.0.8.jar, swagger-models-1.5.22.jar]

We have two swagger dependency version in rest module.

[INFO] +- info.magnolia.bundle:magnolia-community-webapp:pom:6.2-SNAPSHOT:compile
[INFO] | +- info.magnolia.rest:magnolia-rest-services:jar:2.2-SNAPSHOT:compile
[INFO] | | - io.swagger:swagger-annotations:jar:1.5.22:compile
[INFO] | - info.magnolia.restclient:magnolia-rest-client:jar:2.0-SNAPSHOT:compile
[INFO] | +- io.swagger.core.v3:swagger-models:jar:2.0.8:compile
[INFO] | +- io.swagger.parser.v3:swagger-parser-core:jar:2.0.14:compile
[INFO] | - io.swagger.parser.v3:swagger-parser-v3:jar:2.0.14:compile
[INFO] | - io.swagger.core.v3:swagger-core:jar:2.0.9:compile
[INFO] | - io.swagger.core.v3:swagger-annotations:jar:2.0.9:compile
[INFO] - info.magnolia.rest:magnolia-rest-tools:jar:2.2-SNAPSHOT:compile
[INFO] +- io.swagger:swagger-jaxrs:jar:1.5.22:compile
[INFO] | - io.swagger:swagger-core:jar:1.5.22:compile
[INFO] - io.swagger:swagger-models:jar:1.5.22:compile

 

*Notice*
— Swaggers version in BOM —
<swaggerVersion>1.5.22</swaggerVersion>
<swagger-core-version>2.0.8</swagger-core-version>
<swagger-parser-version>2.0.14</swagger-parser-version>

– compile in Dx-core bundle –
swagger-annotations-1.5.22.jar
swagger-annotations-2.0.9.jar
swagger-core-2.0.9.jar
swagger-models-2.0.8.jar
swagger-parser-core-2.0.14.jar
swagger-parser-v3-2.0.14.jar


Generated at Mon Feb 12 00:07:18 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.