[MGNLCE-290] Clean up leftover js-module configuration when upgrading from <6.2.28 Created: 12/Nov/21  Updated: 20/Jun/23

Status: Selected
Project: Community Edition
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Jordie Diepeveen Assignee: Federico Grilli
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Scherm­afbeelding 2023-03-01 om 11.07.56.png    
Issue Links:
Relates
relation
is related to MAGNOLIA-8164 Verify and add Java 17 (LTS) to certi... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Team: Foundation
Work Started:

 Description   

The javascript-models-module has been removed from the webapp bundle since 6.2.28. That's cool!, but it causes errors in the log when upgrading from <6.2.28 as there are some residual configuration stuff left behind.

!Scherm­afbeelding 2023-03-01 om 11.07.56.png|width=284,height=162,thumbnail!

 

 



 Comments   
Comment by Mikaël Geljić [ 12/Nov/21 ]

Hi jdiepeveen,

We are indeed tracking this. Since 6.2 is an LTS version, we cannot abruptly remove it from the bundles, so we chose a conservative approach and document this in the Certified stack.

An exclusion on the webapp pom dependency is enough:

<dependency>
  <groupId>info.magnolia.bundle</groupId>
  <artifactId>magnolia-community-demo-webapp</artifactId>
  <type>pom</type>
  <scope>runtime</scope>
  <exclusions>
    <exclusion>
      <groupId>info.magnolia.javascript-models</groupId>
      <artifactId>magnolia-module-javascript-models</artifactId>
    </exclusion>
  </exclusions>
</dependency> 

We will most likely unbundle it in 6.3 (scope still under review); Alternatively, srhodes has prepared a GraalVM update of the module. See JSMODELS-24 and the git branch for it (considered incubating):
https://git.magnolia-cms.com/projects/MODULES/repos/javascript-models/browse?at=refs%2Fheads%2FJSMODELS-24

In particular, note the section Upgrading to Javascript Models 2.0 in the README.

Cheers,
Mika

Comment by Jordie Diepeveen [ 16/Nov/21 ]

Hi Mika,

I understand. Would be nice if the Certified stack page could be updated with information about the newest LTS release of Java.

Thanks,

Jordie

Comment by Jordie Diepeveen [ 01/Mar/23 ]

Hi,

The javascript-models-module has been removed from the webapp bundle since 6.2.28. That's cool!, but it causes errors in the log when upgrading from <6.2.28 as there are some residual configuration stuff left behind.

!Scherm­afbeelding 2023-03-01 om 11.07.56.png|thumbnail!

Generated at Mon Feb 12 00:07:58 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.