[MGNLCE-34] Provide better expected conditions for 'dialogIsOpen' and 'tabIsOpen' Created: 04/Apr/16 Updated: 02/May/16 Resolved: 26/Apr/16 |
|
| Status: | Closed |
| Project: | Community Edition |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.4.7 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Philip Mundt | Assignee: | Philip Mundt |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 7h | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Epic Link: | Improve QA setup | ||||||||||||
| Sprint: | Basel 41 | ||||||||||||
| Story Points: | 8 | ||||||||||||
| Description |
|
When executing tests on a fast machine, current expected condition dialogIsOpen might be returning true even though the dialog is still in transition. This can become a problem when trying to access element afterwards: they will be found in the DOM but due to the animation/transition still being in progress, selenium is not able to click on the item, resulting in test failure. With this issue we should tackle the most prominent two cases: dialogs and tabs. Thanks to mgeljic who has provided screenshots showing the various states of such a click, we can now provide locators and adjust/add expected conditions. The status' are:
As a result a tab can be considered open when it has the class active and when the app-preloader is gone from the DOM. |