[MGNLCE-60] Remove "too many open files" startup check - if possible thanks to H2 Created: 06/Oct/16  Updated: 17/Mar/17  Resolved: 23/Jan/17

Status: Closed
Project: Community Edition
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Neutral
Reporter: Christopher Zimmermann Assignee: Ilgun Ilgun
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File catalina.out    
Issue Links:
Cloners
is cloned by MGNLEE-465 Remove "too many open files" startup ... Closed
Relates
relates to MGNLCE-7 Stop the installation if the open-fil... Closed
relates to MGNLEE-414 Stop the installation if the open-fil... Closed
relation
is related to MGNLCE-48 Switch default bundle db to H2 Closed
is related to NPMCLI-76 Investigate how newcomers can easily ... Open
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Sprint: Basel 67
Story Points: 3

 Description   

One benefit of switching to H2 is that it opens less file handles than Derby.

After switching to H2, test if the problems due to too many open files are reduced ENOUGH, so that we can remove the check and restriction on Magnolia startup.

Reason:
It is a hurdle for evaluators and new developers to have to change the system settings for handling open files, so it would be an improvement if we could remove this check.
See "too many open files" at https://documentation.magnolia-cms.com/display/DOCS/_Known+issues



 Comments   
Comment by Michael Mühlebach [ 17/Oct/16 ]

Create MGNLEE ticket and remove it there as well — if it actually works.

Comment by Christopher Zimmermann [ 18/Oct/16 ]

And please describe how it was tested.

Comment by Maxime Michel [ 24/Oct/16 ]

Tried with `ulimit -n 256` on my machine and it failed pretty badly. See catalina.out.

Comment by Ilgun Ilgun [ 25/Oct/16 ]

Closed as won't fix due to some systems may still rely on this check.

Comment by Martin Drápela [ 09/Nov/16 ]

No issue with "too many files open" on Debian 8.6.0-amd64-mate-desktop .

Comment by Maxime Michel [ 20/Jan/17 ]

I don't want to be the only one blocking this anymore. It is causing confusion internally: I've seen it in the Support HipChat room, and now for newcomers (NPMCLI-76). We don't need this check in theory, so let's remove it, and see if tickets are being opened. I've just realised I've been running 5.5+ bundles on my private laptop when remote working, and have not seen any issue. I had never done any tuning of system settings for Java on that system, so IMHO this is closer to a newbie machine than my Magnolia development laptop in the office.

Comment by Christopher Zimmermann [ 23/Jan/17 ]

Reopening based on conversation with Ilgun and Maxime.
Please perform an additional test with EEPro bundle and monitor the number of opened files on the system during install and startup.
Additionally, add a large number of YAML definitions to the resources directory at the same time (for example the corporate website) and monitor the open files during this process.

Based on an evaluation of these values we'll decide whether to remove the startup check.

Comment by Maxime Michel [ 24/Jan/17 ]

For the records, this was discussed in planning, where had said we want to keep this test for the time being. Providing a Magnolia Docker image in which we control the environment will probably be a better idea to let people try a one-click, no-friction Magnolia installation.

Comment by Maxime Michel [ 17/Mar/17 ]

Looks like we did the right thing. I'm running Ubuntu now, with a pretty low default file limit. Things had been running fine, until I tried to run both an author and public 5.5.3 EE instances. There I got the exact same `Too many files open` errors as I attached to the ticket.

Generated at Mon Feb 12 00:05:54 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.