[MGNLCMNT-120] Remove STK dependency Created: 12/Mar/15  Updated: 04/May/15  Resolved: 25/Mar/15

Status: Closed
Project: Commenting (closed)
Component/s: None
Affects Version/s: None
Fix Version/s: 2.3

Type: Task Priority: Neutral
Reporter: Federico Grilli Assignee: Federico Grilli
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Release notes required:
Yes
Date of First Response:
Epic Link: Extract STK functionality

 Description   
  • info.magnolia.module.commenting.frontend.action.PageComments uses site
  • info.magnolia.module.commenting.frontend.action.Defaults uses site and STKPageModel


 Comments   
Comment by Philip Mundt [ 19/Mar/15 ]

Module doesn't compile due to checkstyle error:

/Users/johndoe/code/git/modules/commenting/src/main/java/info/magnolia/module/commenting/frontend/action/Defaults.java:44: Javadoc has empty description section.
Comment by Philip Mundt [ 23/Mar/15 ]

From template info/magnolia/module/commenting/frontend/latestComments.ftl CSS class and id were removed.

<div class="${divClass}" ${divID}>

Please re-add them + required init code from /templating-kit/components/teasers/init.inc.ftl.

Some people might rely on class/id for styling purposes.

Comment by Philip Mundt [ 23/Mar/15 ]

Added squashed branch http://git.magnolia-cms.com/gitweb/?p=modules/commenting.git;a=shortlog;h=refs/heads/MGNLCMNT-120-sq

Generated at Mon Feb 12 00:03:20 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.