[MGNLCMNT-20] Make the commenting module site aware. Created: 09/Feb/10 Updated: 16/Mar/23 Resolved: 16/Mar/23 |
|
| Status: | Closed |
| Project: | Commenting (closed) |
| Component/s: | None |
| Affects Version/s: | 1.1 |
| Fix Version/s: | 1.2.x |
| Type: | Improvement | Priority: | Major |
| Reporter: | Rico Jansen | Assignee: | Unassigned |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | commenting, multisite, patch, vpro | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||
| Template: |
|
||||||||||||||||||||
| Patch included: |
Yes
|
||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||
| Description |
|
The commenting module does not use the website as information to store comments, so the comments Enabling this does require someone the create the forum called by this, and set the corresponding Attached is the diff containing:
|
| Comments |
| Comment by Jan Haderka [ 31/Mar/10 ] |
|
Hey Rico, |
| Comment by Rico Jansen [ 31/Mar/10 ] |
|
No problem, the next site which will use commenting where this would be handy will probably be |
| Comment by Jan Haderka [ 31/Mar/10 ] |
|
Few technical comments on the patch itself:
The patch hardcodes the forumName-siteName pattern for the comments forum name and introduces new flag (false by default) whether to suffix forumName with site name or not. That on its own is fine. However when enabling the feature, such forum still needs to be created manually and appropriate roles need to be generated and assigned. Do you think you can improve the patch along the lines of automatic creation of forums and roles per site when site awareness is turned on? |
| Comment by Rico Jansen [ 01/Apr/10 ] |
|
Point 1: An oversight definetly As for the forum name specifying, yes I became aware of that later, so I didn't consider it when making Extending wasn't there yet unfortunately, but creating a paragraph per site is something we try to Auto creation of forums I have considered, but not by observation though, that is an area I haven't |
| Comment by Magnolia International [ 29/Nov/10 ] |
|
Finally applied this patch! Do you guys have any use for this "useSiteName" parameter you introduced, or is it just to avoid breaking existing installs ? In |
| Comment by Rico Jansen [ 29/Nov/10 ] |
|
It was purely for protection against breaking existing installs. So you could keep the old |
| Comment by Eric Hechinger [ 14/Mar/12 ] |
|
Currently with EE, this is not working, simply because we still have the property forumName (= pagecomments) defined under In PageComments.determineForumToUse() the forumName = the property defined prefiously. If it's not defined, this value will be pagecomments-demo-project_en. It seems for me that we have with EE the simple site behavior of CE (we could simply remove the commenting/templates/components/comments/parameters property when installing EE). |
| Comment by Adam Jones [ 16/Mar/23 ] |
|
Closing due to project being archived. |