[MGNLCMNT-35] Do we need to keep support for forum names set in paragraph definitions ? Created: 29/Nov/10 Updated: 09/Dec/13 Resolved: 09/Dec/13 |
|
| Status: | Closed |
| Project: | Commenting (closed) |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.x |
| Type: | Task | Priority: | Major |
| Reporter: | Magnolia International | Assignee: | Unassigned |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoR: |
Empty
|
| Date of First Response: |
| Description |
|
Now that we have multi-locale and multi-site commenting support, is it still useful to have the possibility to configure a forumName in paragraph definitions ? It clutters the code of the LatestComments and PageComments model classes, perhaps unnecessarily. |
| Comments |
| Comment by Jan Haderka [ 29/Nov/10 ] |
|
if different site is the only reason for using different forum then perhaps not. But I'm not sure that it is the case. What if you have big site and want different forums used for different parts of the website? |
| Comment by Magnolia International [ 29/Nov/10 ] |
|
I'd argue you should probably override the commenting model classes to cover your needs in such cases (there is - or will be when i'm finished with cleaning up - methods to "determine forum to use") .. or use actual different sites ? .. or we should split the class ourselves for those 2 usecases ("auto-detection-of-forum" vs "hardcoded-forum"), but one probably wants the best of both worlds (ie auto-detection with a configured pattern) |
| Comment by Jan Haderka [ 29/Nov/10 ] |
|
Fair enough ... let's remove it once those methods are in place. |
| Comment by Christoph Meier [ 09/Dec/13 ] |
|
seems obsolete. |