[MGNLCMNT-57] Commenting form is showing to all users if there is no comments posted Created: 11/Jan/12 Updated: 18/Feb/16 Resolved: 18/Feb/16 |
|
| Status: | Closed |
| Project: | Commenting (closed) |
| Component/s: | client-ui, security, Template |
| Affects Version/s: | 1.1.3, 1.1.4 |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Zarko Ivanoski | Assignee: | Unassigned |
| Resolution: | Won't Do | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
Commenting form should not be shown to users that has no rights to post comments. In PageComments class there is method "isAllowedToPost" that check is user has right to post. But in case where there are no comments posted, it returns true value so form will be shown to all users. public boolean isAllowedToPost() { else { return super.isAllowedToPost(); }} Maybe this feature is planned to restrict posting comments to some of users by checking user rights to post on specific comments thread but in that case maybe there is need of another method that will be used in comments.inc.ftl only for showing the form. If that is not the idea, this method should only check user rights for all comments thread in forum. |
| Comments |
| Comment by Jan Haderka [ 11/Jan/12 ] |
|
You are absolutely right. This is a bug. Thanks for your report. |
| Comment by Christoph Meier [ 07/Feb/14 ] |
|
Since commenting-function should be accessible for anoymous users, this will be come obsolete quite soon (see |
| Comment by Christoph Meier [ 14/Mar/14 ] |
|
Per default commenting is now enabled for anonymous user, so in that case that's no more an issue. |
| Comment by Michael Mühlebach [ 18/Feb/16 ] |
|
Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes. |