[MGNLCMNT-85] i18n: Mark hard coded strings in commenting module Created: 24/Sep/13  Updated: 19/Nov/13  Resolved: 13/Nov/13

Status: Closed
Project: Commenting (closed)
Component/s: None
Affects Version/s: 2.0.1
Fix Version/s: None

Type: Task Priority: Neutral
Reporter: Cheng Hu Assignee: Christopher Zimmermann
Resolution: Outdated Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MGNLUI-2131 i18n: use new i18n for all text in Ma... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Sprint: 5.1 - Final

 Comments   
Comment by Magnolia International [ 07/Oct/13 ]

No attached commit, no apparent diff related to i18n since 2.0

Comment by Jan Haderka [ 08/Oct/13 ]

What? I see the commit in git commit tab. http://git.magnolia-cms.com/gitweb/?p=modules/commenting.git;a=blobdiff;f=src/main/java/info/magnolia/module/commenting/CommentingModule.java;h=81d3910d63599394a30686971b4bef914c0fd60e;hb=6cad53b9191cd2d6674a9cba89b3d3ff10f99c0e;hp=36c9ef682259ec19e1d137ac850b9357b936ece5;hpb=35190a2d5f404f74a50dd16fab9ed10a455a763c

OMG this went on i18n branch and was never ported to master. This issue is indeed NOT solved in 2.0.1.

Comment by Christopher Zimmermann [ 13/Nov/13 ]

it was decided not to tackle i18n on commenting module. Commit on branch does not need to be integrated on master.

Generated at Mon Feb 12 00:03:01 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.