[MGNLCMNT-95] Allow dependency to 5.2.2 (main and UI) and STK Created: 06/Feb/14  Updated: 20/Feb/14  Resolved: 19/Feb/14

Status: Closed
Project: Commenting (closed)
Component/s: None
Affects Version/s: None
Fix Version/s: 2.2

Type: Improvement Priority: Neutral
Reporter: Christoph Meier Assignee: Christoph Meier
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLFORUM-230 Allow dependency to 5.2.2 (main and UI) Closed
Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

Allow dependency to 5.2.2 (main and UI)



 Comments   
Comment by Roman Kovařík [ 19/Feb/14 ]
  1. This ticket is called Allow dependency to 5.2.2 (main and UI), but actually also raising the dependency to STK and adds migration module. Please update title and explain reason for that update in the description .
  2. Dependency STK is not in the module descriptor.
  3. No need to add dependency to migration, the line:
    ComponentsTestUtil.setImplementation(ReportingService.class, DefaultReportingService.class); in CommentingModuleVersionHandlerTest is obsolete and should be removed.
Comment by Christoph Meier [ 19/Feb/14 ]

I removed raising the dependency to STK; this was done due "another reason"/idea which is not possible, currently. I changed it back to 2.7.

Dependency to STK cannot be in the module descriptor of commenting, since the STK module descriptor istself has a optional dep. to commenting; both directions is not possible as far as i know.
The dep. of commenting to STK in the pom has only <scope>provided</scope>.

That dependency to migration i added to let compile CommentingModuleVersionHandlerTest, but since <<ComponentsTestUtil.setImplementation(ReportingService.class, DefaultReportingService.class); in CommentingModuleVersionHandlerTest is obsolete and should>> is not used, i removed it agian.

Generated at Mon Feb 12 00:03:06 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.