[MGNLCT-310] 'name' property on Submodel is not stored (Norsu) Created: 09/Nov/22  Updated: 11/Jan/23  Resolved: 11/Jan/23

Status: Closed
Project: Content Types
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Christopher Zimmermann Assignee: Canh Nguyen
Resolution: Obsolete Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File ct-310-response.png     PNG File ct-310.png     PNG File norsu-name-not-saved.png    
Issue Links:
Relates
relates to MGNLCT-311 'name' property on Model is not retur... Closed
dependency
supersession
is superseded by MGNLCT-347 Norsu-based contenttype uses '$type: ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: SaaS TPR - ContentTypes
Team: DeveloperX

 Description   

On a norsu contenttype based app, if aa submodel has a property called 'name', the field is displayed as expecged in the editor subapp, but the value is not properly saved.

I'm not sure if this is something for DevX team or maybe nucleus team.

Expected:

name field in the "guides" section shows the value entered in "name" field.

Actual:

name field shows: "guides[0]"

Notes:

The field works as expected on JCR-based ContentType.

The delivery endpoint REST response does not include a `name` or `@metadata/@name` property.

 

The contenttype definition:

 

datasource:
  $type: norsuContentTypeDatasource
  workspace: norsu-activities
  autoCreate: true
  
model:
  nodeType: activity
  properties:
    name:
      label: Name
      i18n: true
      required: true
    description:
      type: richText
      label: Description
      i18n: true
      required: false
    image:
      type: asset
    email:
      label: Email
      multiple: true
    guides:
      type: Guide
      label: Guides
      multiple: true  

subModels:
    - name: Guide
      properties:
        - name: name
          label: Name
        - name: phoneNumber
          label: Phone Number


 

 

 



 Comments   
Comment by Christopher Zimmermann [ 16/Nov/22 ]

See slack Nucleuss: https://magnolia-cms.slack.com/archives/C02RSFYAH6D/p1668512465833999

Comment by Christopher Zimmermann [ 28/Nov/22 ]

Flag added

Waiting for MGNLCT-311

Comment by Oanh Thai Hoang [ 01/Dec/22 ]

This is just a proposal. With this PR: https://git.magnolia-cms.com/projects/CLOUD/repos/norsu/pull-requests/268/overview

 

And define mgnl:name and name explicitly as below:

 

datasource:
  $type: norsuContentTypeDatasource
  workspace: magnolia-travels
  autoCreate: true
  
model:
  properties:
    - name: name
      label: Name
      i18n: true
      required: true
    - name: mgnl:name
      label: mgnl:name
      i18n: true
      required: true
    - name: guides
      type: Guide
      label: Guides
      multiple: true
  subModels:
    - name: Guide
      properties:
        - name: name
          label: Name
        - name: phoneNumber
          label: Phone Number 

we will get what we want: 

rest response:

Comment by Christopher Zimmermann [ 20/Dec/22 ]

Depends upon the result of the Spike which has been agreed upon aafter a number of meetings. See https://jira.magnolia-cms.com/browse/NORSU-907

Generated at Mon Feb 12 00:39:05 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.